Skip to content

Jump to next e-mail after archiving current one on inbox tab #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WhiteSoxx
Copy link

@WhiteSoxx WhiteSoxx commented Apr 7, 2025

Updates

apps/web/components/email-list/EmailList.tsx:

  • Added a nextEmail variable, storing the id of the next thread item in the threads list, that being the next e-mail shown on the inbox tag.

  • nextEmail is used to immediately open said e-mail when archiving the one currently open in the panel. This new e-mail is immediately loaded in while the previous one is being archived in the background.

Closes #163

Summary by CodeRabbit

  • New Features
    • Improved email archiving interaction: after archiving an email, the interface now automatically selects the next available email, streamlining your workflow.

Copy link

vercel bot commented Apr 7, 2025

@WhiteSoxx is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

coderabbitai bot commented Apr 7, 2025

Walkthrough

This change updates the onArchive callback in the EmailList component. After an email thread is archived, the code retrieves the index of the archived email from the list and, if a subsequent thread exists, updates the state to automatically select it as the open thread.

Changes

File Change Summary
apps/web/components/.../EmailList.tsx Enhanced onArchive to automatically set openThreadId to the next email thread

Sequence Diagram(s)

sequenceDiagram
    participant User as User
    participant EL as EmailList Component
    User->>EL: Triggers archive on email thread
    EL->>EL: Archive the email
    EL->>EL: Determine index of archived thread in threads array
    alt Next thread exists
        EL->>EL: Set openThreadId to next thread's ID
        EL->>User: Display the next email thread
    else No further thread
        EL->>User: Remain on current state
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
When archiving an email it should jump to the next email in the list (#163)

Possibly related PRs

Poem

I'm a rabbit, quick on my feet,
Archiving emails with a happy beat.
Each tap now leads me to the next in line,
Hopping through threads, feeling just fine.
Code and carrots—both taste divine!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/components/email-list/EmailList.tsx

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f7c28a and 12406c3.

📒 Files selected for processing (1)
  • apps/web/components/email-list/EmailList.tsx (1 hunks)
🔇 Additional comments (1)
apps/web/components/email-list/EmailList.tsx (1)

228-233: Great UX improvement!

This automatically navigates to the next email after archiving, creating a smoother workflow for users who are processing multiple emails. The implementation logic is clear and handles the edge case where there might not be a next email.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When archiving an email it should jump to the next email in the list
2 participants