[ci] Update 'latest' version of node to v24. NFC #24449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, instead of pinning it at 24, we could call this |
The idea is that current is supposed to be LTS, which would be 22.16... that also needs updating :) |
|
Oh wait.. I misread your comment. Will update. |
sbc100
changed the title
|
Done. |
kripken
approved these changes
May 30, 2025
brendandahl
approved these changes
May 30, 2025
sbc100
force-pushed
the
node24
branch
2 times, most recently
from
650f2de to
066d677
Compare
This was referenced Jun 2, 2025
sbc100
added a commit
that referenced
this pull request
Jun 2, 2025
The wasm64 tests modes already require this. Split out from #24449
Also update wasm-esm-integration tests to require v24 rather than canary.
kripken
reviewed
Jun 3, 2025
| @@ -1070,6 +1077,7 @@ jobs: | |||
| EMTEST_SKIP_SCONS: "1" | |||
| EMTEST_SKIP_RUST: "1" | |||
| EMTEST_SKIP_NODE_CANARY: "1" | |||
| EMTEST_SKIP_ESM_INTEGRATION: "1" | |||
There was a problem hiding this comment.
Where is this not skipped, after this PR?
There was a problem hiding this comment.
Anywhere that has node 24 or above installed
There was a problem hiding this comment.
We could replace this with EMTEST_SKIP_SKIP_NODE24 I suppose but the general approach so far seems to be per-feature flags.
kripken
approved these changes
Jun 3, 2025
|
Actually it looks like we can simplify things by landing this first: #24478 |
RReverser
pushed a commit
to RReverser/emscripten
that referenced
this pull request
Jun 5, 2025
…en-core#24465) The wasm64 tests modes already require this. Split out from emscripten-core#24449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now use this for testing wasm64 and esm integration.