[test] Remove redundant calls to require_node_canary. NFC
#24465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wasm64 tests modes already require this
sbc100
changed the title
require_node_canaryrequire_node_canary. NFC
Where can I find that? I looked at |
|
There are no wasm64 feature that are in canary (25) that are not in node 24 (that I know of) |
|
Thanks, now I understand. I was looking for canary specifically. |
kripken
approved these changes
Jun 2, 2025
RReverser
pushed a commit
to RReverser/emscripten
that referenced
this pull request
Jun 5, 2025
…en-core#24465) The wasm64 tests modes already require this. Split out from emscripten-core#24449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wasm64 tests modes already require this.
Split out from #24449