[release/v1.4] fix: make topology injector best effort (#5891) (#5895)

fix: make topology injector best effort (#5891)

* fix: make topology injector best effort

* allow pods even if there is an internal error
in the webhook processing the request

Relates to #5890



* fix build



---------


(cherry picked from commit 5b8269d)

Signed-off-by: Arko Dasgupta <[email protected]>

Author: arkodg

internal/provider/kubernetes/topology_injector.go

@@ -8,7 +8,6 @@ package kubernetes
 import (
 	"context"
 	"fmt"
-	"net/http"
 
 	"github.com/go-openapi/jsonpointer"
 	corev1 "k8s.io/api/core/v1"
@@ -31,7 +30,7 @@ func (m *ProxyTopologyInjector) Handle(ctx context.Context, req admission.Reques
 	if err := m.Decoder.Decode(req, binding); err != nil {
 		klog.Error(err, "decoding binding failed", "request.ObjectKind", req.Object.Object.GetObjectKind())
 		topologyInjectorEventsTotal.WithFailure(metrics.ReasonError).Increment()
-		return admission.Errored(http.StatusInternalServerError, err)
+		return admission.Allowed("internal error, skipped")
 	}
 
 	if binding.Target.Name == "" {
@@ -48,7 +47,7 @@ func (m *ProxyTopologyInjector) Handle(ctx context.Context, req admission.Reques
 	if err := m.Get(ctx, podName, pod); err != nil {
 		klog.Error(err, "get pod failed", "pod", podName.String())
 		topologyInjectorEventsTotal.WithFailure(metrics.ReasonError).Increment()
-		return admission.Errored(http.StatusInternalServerError, err)
+		return admission.Allowed("internal error, skipped")
 	}
 
 	// Skip non-proxy pods
@@ -65,7 +64,7 @@ func (m *ProxyTopologyInjector) Handle(ctx context.Context, req admission.Reques
 	if err := m.Get(ctx, nodeName, node); err != nil {
 		klog.Error(err, "get node failed", "node", node.Name)
 		topologyInjectorEventsTotal.WithFailure(metrics.ReasonError).Increment()
-		return admission.Errored(http.StatusInternalServerError, err)
+		return admission.Allowed("internal error, skipped")
 	}
 
 	var patch string
@@ -77,7 +76,7 @@ func (m *ProxyTopologyInjector) Handle(ctx context.Context, req admission.Reques
 	if err := m.Patch(ctx, pod, rawPatch); err != nil {
 		klog.Error(err, "patch pod failed", "pod", podName.String())
 		topologyInjectorEventsTotal.WithFailure(metrics.ReasonError).Increment()
-		return admission.Errored(http.StatusInternalServerError, err)
+		return admission.Allowed("internal error, skipped")
 	}
 	klog.V(1).Info("patch pod succeeded", "pod", podName.String())
 	topologyInjectorEventsTotal.WithSuccess().Increment()