[release/v1.4] fix: make topology injector best effort (#5891) #5895
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: make topology injector best effort * allow pods even if there is an internal error in the webhook processing the request Relates to envoyproxy#5890 Signed-off-by: Arko Dasgupta <[email protected]> * fix build Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 5b8269d) Signed-off-by: Arko Dasgupta <[email protected]>
guydc
approved these changes
May 1, 2025
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/v1.4 #5895 +/- ##
================================================
- Coverage 65.16% 65.15% -0.02%
================================================
Files 224 224
Lines 35857 35857
================================================
- Hits 23368 23364 -4
- Misses 11044 11047 +3
- Partials 1445 1446 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: make topology injector best effort
allow pods even if there is an internal error in the webhook processing the request
Relates to #5890
(cherry picked from commit 5b8269d)