Skip to content

Topology injector blocking envoy proxy from starting #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arkodg opened this issue May 1, 2025 · 3 comments · Fixed by #5911
Closed

Topology injector blocking envoy proxy from starting #5890

arkodg opened this issue May 1, 2025 · 3 comments · Fixed by #5911
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented May 1, 2025

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: The expected value isn't returned, etc.

Noticed envoy-proxy pods were not starting

Conditions:
  Type           Status  Reason
  ----           ------  ------
  Available      False   MinimumReplicasUnavailable
  Progressing    True    ReplicaSetUpdated

in the envoy gateway logs, I noticed topology injector failures

2025-05-01T15:58:03.840Z	ERROR	provider	kubernetes/topology_injector.go:78	error decoding patch: unexpected end of JSON inputpatch pod failedpodenvoy-gateway-system/envoy-default-eg-e41e7b31-654ccf5f87-mw6hk	{"runner": "provider"}

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:

Include the environment like gateway version, envoy version and so on.

Logs:

Include the access logs and the Envoy logs.

@arkodg arkodg added triage kind/bug Something isn't working and removed triage labels May 1, 2025
@arkodg arkodg added this to the v1.4.0 milestone May 1, 2025
arkodg added a commit to arkodg/gateway that referenced this issue May 1, 2025
* allow pods even if there is an internal error
in the webhook processing the request

Relates to envoyproxy#5890

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit that referenced this issue May 1, 2025
* fix: make topology injector best effort

* allow pods even if there is an internal error
in the webhook processing the request

Relates to #5890

Signed-off-by: Arko Dasgupta <[email protected]>

* fix build

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit to arkodg/gateway that referenced this issue May 1, 2025
* fix: make topology injector best effort

* allow pods even if there is an internal error
in the webhook processing the request

Relates to envoyproxy#5890

Signed-off-by: Arko Dasgupta <[email protected]>

* fix build

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 5b8269d)
Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit that referenced this issue May 1, 2025
fix: make topology injector best effort (#5891)

* fix: make topology injector best effort

* allow pods even if there is an internal error
in the webhook processing the request

Relates to #5890



* fix build



---------


(cherry picked from commit 5b8269d)

Signed-off-by: Arko Dasgupta <[email protected]>
@jukie
Copy link
Contributor

jukie commented May 2, 2025

Sorry for introducing this bug, working on a fix for it!

@jukie
Copy link
Contributor

jukie commented May 2, 2025

/assign @jukie

@arkodg
Copy link
Contributor Author

arkodg commented May 2, 2025

thanks @jukie !

melsal13 pushed a commit to melsal13/gatewayPersonal that referenced this issue May 7, 2025
* fix: make topology injector best effort

* allow pods even if there is an internal error
in the webhook processing the request

Relates to envoyproxy/gateway#5890

Signed-off-by: Arko Dasgupta <[email protected]>

* fix build

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: melsal13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants