Skip to content

enhancement: add api-version for load #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2025
Merged

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Apr 25, 2025

What type of PR is this?

What this PR does / why we need it:

  • Add support for ReferenceGrant in load
  • Add APIVersion field for each loaded resources

This is needed for #5767

Which issue(s) this PR fixes:

Release Notes: Yes/No

@shawnh2 shawnh2 requested a review from a team as a code owner April 25, 2025 13:51
arkodg
arkodg previously approved these changes Apr 25, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team April 25, 2025 14:37
Signed-off-by: shawnh2 <[email protected]>
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 82.05128% with 14 lines in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (096cb8d) to head (9bf5e82).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/resource/load.go 82.05% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5816      +/-   ##
==========================================
+ Coverage   65.19%   65.21%   +0.01%     
==========================================
  Files         214      219       +5     
  Lines       34321    34918     +597     
==========================================
+ Hits        22377    22773     +396     
- Misses      10591    10761     +170     
- Partials     1353     1384      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shawnh2 shawnh2 requested a review from arkodg April 26, 2025 08:14
@arkodg arkodg merged commit e0c4d47 into envoyproxy:main Apr 26, 2025
25 checks passed
@shawnh2 shawnh2 deleted the improve-load branch April 26, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants