-
Notifications
You must be signed in to change notification settings - Fork 460
feat: implement offline kubernetes controller #5767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5767 +/- ##
==========================================
+ Coverage 65.29% 65.40% +0.11%
==========================================
Files 216 217 +1
Lines 35907 36061 +154
==========================================
+ Hits 23445 23586 +141
+ Misses 11007 10999 -8
- Partials 1455 1476 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @shawnh2 this PR adds the "offline controller," but it doesn’t include an example of how to actually use it. Since it's just a small change, could we also include the file provider modification as part of this PR to verify it works? Thanks! |
sure, I was intend to include file provider in next PR. I will add it then. |
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
@shawnh2 can you rebase ? |
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Signed-off-by: melsal13 <[email protected]>
Signed-off-by: melsal13 <[email protected]>
What type of PR is this?
What this PR does / why we need it:
impl offline controller detailed in #3213 (comment) and let file-provider to be able to utilise offline controller.
Which issue(s) this PR fixes:
fix #3213
Release Notes: Yes