Skip to content

feat: implement offline kubernetes controller #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 7, 2025

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Apr 19, 2025

What type of PR is this?

What this PR does / why we need it:

impl offline controller detailed in #3213 (comment) and let file-provider to be able to utilise offline controller.

Which issue(s) this PR fixes:

fix #3213

Release Notes: Yes

@shawnh2 shawnh2 requested a review from a team as a code owner April 19, 2025 06:58
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

Attention: Patch coverage is 66.81716% with 147 lines in your changes missing coverage. Please review.

Project coverage is 65.40%. Comparing base (6b772d7) to head (6c46dd9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/file/store.go 45.83% 76 Missing and 28 partials ⚠️
internal/provider/kubernetes/controller_offline.go 81.01% 13 Missing and 2 partials ⚠️
internal/provider/file/status.go 77.77% 9 Missing and 3 partials ⚠️
internal/provider/file/file.go 80.48% 5 Missing and 3 partials ⚠️
internal/provider/kubernetes/indexers.go 93.05% 0 Missing and 5 partials ⚠️
internal/provider/runner/runner.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5767      +/-   ##
==========================================
+ Coverage   65.29%   65.40%   +0.11%     
==========================================
  Files         216      217       +1     
  Lines       35907    36061     +154     
==========================================
+ Hits        23445    23586     +141     
+ Misses      11007    10999       -8     
- Partials     1455     1476      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhaohuabing
Copy link
Member

zhaohuabing commented Apr 21, 2025

Hi @shawnh2 this PR adds the "offline controller," but it doesn’t include an example of how to actually use it. Since it's just a small change, could we also include the file provider modification as part of this PR to verify it works?

Thanks!

@shawnh2
Copy link
Contributor Author

shawnh2 commented Apr 21, 2025

Hi @shawnh2 this PR adds the "offline controller," but it doesn’t include an example of how to actually use it. Since it's just a small change, could we also include the file provider modification as part of this PR to verify it works?

Thanks!

sure, I was intend to include file provider in next PR. I will add it then.

@shawnh2 shawnh2 marked this pull request as draft April 26, 2025 01:55
@shawnh2 shawnh2 marked this pull request as ready for review April 30, 2025 12:20
@shawnh2 shawnh2 added this to the v1.4.0 milestone Apr 30, 2025
Signed-off-by: shawnh2 <[email protected]>
@shawnh2
Copy link
Contributor Author

shawnh2 commented Apr 30, 2025

The status works as expected
Snipaste_2025-04-30_21-26-50

arkodg
arkodg previously approved these changes May 5, 2025
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team May 5, 2025 16:01
@arkodg
Copy link
Contributor

arkodg commented May 5, 2025

@shawnh2 can you rebase ?

Signed-off-by: shawnh2 <[email protected]>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@shawnh2 shawnh2 merged commit 80ef500 into envoyproxy:main May 7, 2025
23 of 25 checks passed
@shawnh2 shawnh2 deleted the offline-controller branch May 7, 2025 07:42
melsal13 referenced this pull request in melsal13/gatewayPersonal May 7, 2025
melsal13 referenced this pull request in melsal13/gatewayPersonal May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor the kubernetes provider to be provider-agnostic
3 participants