Skip to content

Update the Decision-making process and transparency #20033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented May 27, 2025

Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.27%. Comparing base (a091a6d) to head (989dd8e).
Report is 17 commits behind head on main.

Additional details and impacted files

see 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20033      +/-   ##
==========================================
- Coverage   69.28%   69.27%   -0.01%     
==========================================
  Files         413      413              
  Lines       34364    34364              
==========================================
- Hits        23810    23807       -3     
- Misses       9159     9164       +5     
+ Partials     1395     1393       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a091a6d...989dd8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jberkus
Copy link

jberkus commented May 28, 2025

Seems fine to me, but given, we should get +1s from all leads.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for working on it @ahrtr as discussed on etcd leads call.
A small comment inline :) but LGTM.

@ahrtr ahrtr force-pushed the 20250527_transparency branch from a3a353f to 1991f09 Compare May 28, 2025 16:45
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for putting this together, Ben.

I'm a little hesitant with the third bullet point:

- Private Slack group threads involving sig-etcd leads and maintainers

I don't know if we should emphasize group, but the last paragraph mentions "After reaching rough consensus within this group", so it may be irrelevant.

@ahrtr ahrtr force-pushed the 20250527_transparency branch from 1991f09 to a46e2bf Compare May 29, 2025 08:28
@ahrtr
Copy link
Member Author

ahrtr commented May 29, 2025

LGTM. Thanks for putting this together, Ben.

I'm a little hesitant with the third bullet point:

- Private Slack group threads involving sig-etcd leads and maintainers

I don't know if we should emphasize group, but the last paragraph mentions "After reaching rough consensus within this group", so it may be irrelevant.

While these three channels are not fully open to the public, they are accessible to a well-defined group. As long as we clearly specify who should be involved in the discussions, this setup should be acceptable.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, ivanvc, jmhbnz, spzala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,fuweid,jmhbnz,spzala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr requested review from serathius, wenjiaswe and jberkus May 29, 2025 19:51
@wenjiaswe
Copy link
Contributor

cc k8s steering committee @BenTheElder, Ben, could you (or point us to the right contact( please kindly take a look to make sure this comply with k8s, CNCF governance? Thanks!

@BenTheElder
Copy link

BenTheElder commented Jun 2, 2025

cc k8s steering committee @BenTheElder, Ben, could you (or point us to the right contact( please kindly take a look to make sure this comply with k8s, CNCF governance? Thanks!

That's an interesting question, typically SIGs would be expected to document non-standard governance in the charter's "deviations from sig governance" section: https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance

cc-ed the rest of the committee at https://kubernetes.slack.com/archives/CPNFRNLTS/p1748887137437919 since @kubernetes/steering-committee won't work here.

Some SIGs do have documented and approved deviations, otherwise things like leadership changes have standard documented processes like https://github.com/kubernetes/community/blob/master/contributors/chairs-and-techleads/leadership-changes.md

@ahrtr ahrtr force-pushed the 20250527_transparency branch 2 times, most recently from 001b9f8 to 0397a97 Compare June 2, 2025 18:14
@ahrtr
Copy link
Member Author

ahrtr commented Jun 2, 2025

Some SIGs do have documented and approved deviations, otherwise things like leadership changes have standard documented processes like https://github.com/kubernetes/community/blob/master/contributors/chairs-and-techleads/leadership-changes.md

thx for pointing us to the standard document.

This guide doesn't conflict with the official guide; it supplements it instead. Essentially, it just enhance the first item "Discuss the proposed changes with the current leadership" with "Openly and transparently discuss the proposed changes with the current leadership".

Also we expect:

Any significant changes affecting the etcd community, including but not limited to
leadership transitions, governance updates, or project-wide process changes, must
first be discussed transparently within the current [OWNERS]

@ahrtr
Copy link
Member Author

ahrtr commented Jun 2, 2025

This guide doesn't conflict with the official guide; it supplements it instead. Essentially, it just enhance the first item "Discuss the proposed changes with the current leadership" with "Openly and transparently discuss the proposed changes with the current leadership".

I can also send a PR to update the doc as well if it's desired.

@wenjiaswe
Copy link
Contributor

This guide doesn't conflict with the official guide; it supplements it instead. Essentially, it just enhance the first item "Discuss the proposed changes with the current leadership" with "Openly and transparently discuss the proposed changes with the current leadership".

I can also send a PR to update the doc as well if it's desired.

Yes, that's a good idea. We could also link this doc there. I am sure the reviewers there will let us know if anything missing too.

@wenjiaswe
Copy link
Contributor

wenjiaswe commented Jun 2, 2025

I also left some comments, will LGTM once addressed.

@BenTheElder @ahrtr we could do one of the following:

  1. update both https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance and this doc here
  2. update this doc, and add the link of this doc to https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance
  3. update https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance, and add the link of that doc here

I don't have a strong opinion, as long as we have clear policy that's easy to find for both etcd and kubernetes community. I am slightly in favor of either option 2 or option 3, so that we don't have to update 2 places every time.

@jmhbnz @ivanvc @serathius ?

@BenTheElder
Copy link

This guide doesn't conflict with the official guide; it supplements it instead. Essentially, it just enhance the first item "Discuss the proposed changes with the current leadership" with "Openly and transparently discuss the proposed changes with the current leadership".

I can also send a PR to update the doc as well if it's desired.

I don't think the content itself is particularly controversial, but there is an expectation for review of SIG charter and governance changes and explicitly calling out where things deviate.

I would add this content to the SIG document and update this doc to link to the SIG community directory.
That way we can also reconcile any future updates and this content is discoverable to the broader community.

But that's just my personal thought, the steering committee has documented consensus requirements:
https://github.com/kubernetes/steering/blob/main/charter.md#voting

@ahrtr
Copy link
Member Author

ahrtr commented Jun 3, 2025

Raised kubernetes/community#8475

@ahrtr ahrtr removed the request for review from jberkus June 5, 2025 17:12
@ahrtr ahrtr force-pushed the 20250527_transparency branch from 0397a97 to 989dd8e Compare June 10, 2025 09:28
@ahrtr
Copy link
Member Author

ahrtr commented Jun 10, 2025

The change has integrated into sig-etcd charter via kubernetes/community#8475, so updated this PR to link to SIG-etcd governance.

@ahrtr
Copy link
Member Author

ahrtr commented Jun 10, 2025

/test pull-etcd-e2e-arm64

@ahrtr ahrtr merged commit 9bc99b1 into etcd-io:main Jun 12, 2025
33 checks passed
@ahrtr ahrtr deleted the 20250527_transparency branch June 12, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

9 participants