-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Update the Decision-making process and transparency #20033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 27 files with indirect coverage changes @@ Coverage Diff @@
## main #20033 +/- ##
==========================================
- Coverage 69.28% 69.27% -0.01%
==========================================
Files 413 413
Lines 34364 34364
==========================================
- Hits 23810 23807 -3
- Misses 9159 9164 +5
+ Partials 1395 1393 -2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Seems fine to me, but given, we should get +1s from all leads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for working on it @ahrtr as discussed on etcd leads call.
A small comment inline :) but LGTM.
a3a353f
to
1991f09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ahrtr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for putting this together, Ben.
I'm a little hesitant with the third bullet point:
- Private Slack group threads involving sig-etcd leads and maintainers
I don't know if we should emphasize group, but the last paragraph mentions "After reaching rough consensus within this group", so it may be irrelevant.
1991f09
to
a46e2bf
Compare
While these three channels are not fully open to the public, they are accessible to a well-defined group. As long as we clearly specify who should be involved in the discussions, this setup should be acceptable. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc, jmhbnz, spzala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc k8s steering committee @BenTheElder, Ben, could you (or point us to the right contact( please kindly take a look to make sure this comply with k8s, CNCF governance? Thanks! |
That's an interesting question, typically SIGs would be expected to document non-standard governance in the charter's "deviations from sig governance" section: https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance cc-ed the rest of the committee at https://kubernetes.slack.com/archives/CPNFRNLTS/p1748887137437919 since @kubernetes/steering-committee won't work here. Some SIGs do have documented and approved deviations, otherwise things like leadership changes have standard documented processes like https://github.com/kubernetes/community/blob/master/contributors/chairs-and-techleads/leadership-changes.md |
001b9f8
to
0397a97
Compare
thx for pointing us to the standard document. This guide doesn't conflict with the official guide; it supplements it instead. Essentially, it just enhance the first item " Also we expect:
|
I can also send a PR to update the doc as well if it's desired. |
Yes, that's a good idea. We could also link this doc there. I am sure the reviewers there will let us know if anything missing too. |
I also left some comments, will LGTM once addressed. @BenTheElder @ahrtr we could do one of the following:
I don't have a strong opinion, as long as we have clear policy that's easy to find for both etcd and kubernetes community. I am slightly in favor of either option 2 or option 3, so that we don't have to update 2 places every time. |
I don't think the content itself is particularly controversial, but there is an expectation for review of SIG charter and governance changes and explicitly calling out where things deviate. I would add this content to the SIG document and update this doc to link to the SIG community directory. But that's just my personal thought, the steering committee has documented consensus requirements: |
Raised kubernetes/community#8475 |
Signed-off-by: Benjamin Wang <[email protected]>
0397a97
to
989dd8e
Compare
The change has integrated into sig-etcd charter via kubernetes/community#8475, so updated this PR to link to SIG-etcd governance. |
/test pull-etcd-e2e-arm64 |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
cc @fuweid @ivanvc @jmhbnz @serathius @siyuanfoundation @spzala @wenjiaswe @jberkus