-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update sig-etcd charter to link to etcd's GOVERNANCE.md #8475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sig-etcd/charter.md
Outdated
@@ -46,8 +46,10 @@ and opts-in to updates and modifications to [sig-governance]. | |||
- Email: [etcd-dev](https://groups.google.com/forum/?hl=en#!forum/etcd-dev). | |||
- Slack: [#etcd](https://kubernetes.slack.com/messages/C3HD8ARJ5/details/) channel on Kubernetes. | |||
- SIG etcd contributing instructions ([CONTRIBUTING.md]) be defined in etcd project. | |||
- SIG etcd governance instructions ([GOVERNANCE.md]) be defined in etcd project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this needs to be defined here and the link direction reversed so it will be reviewed and approved as any other SIG charter.
I don't think we should have SIG governance out of band.
/assign @kubernetes/steering-committee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this needs to be defined here and the link direction reversed so it will be reviewed and approved as any other SIG charter.
I don't think we should have SIG governance out of band.
From SIG perspective, it's true. But etcd is also a project under CNCF. Both share the same GOVERNANCE.md
. From that perspective, keeping the GOVERNANCE.md
in the etcd repo might be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think there is a dual governance model https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance and that looks like an argument for fragmentation for SIGs
... At first sight I prefer am holistic and cohesive model for governance for all sigs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first sight I prefer am holistic and cohesive model for governance for all sigs
I am OK to close this PR and etcd-io/etcd#20033 if we can update the https://github.com/kubernetes/community/blob/master/contributors/chairs-and-techleads/leadership-changes.md.
The motivation behind etcd-io/etcd#20033 is to reinforce the importance of open and transparent processes.
For any proposed leadership change within a SIG, the changes should first be discussed openly with the full current leadership team. These discussions must take place in a transparent and shared setting (e.g., a group email or slack thread or a SIG leads meeting), rather than through private or one-on-one conversations.
Private discussions are an individual's right and should not be restricted or interfered with by others. However, it is important to avoid a situation where individuals are privately consulted in isolation and the proposal is then shared with the broader community without prior open discussion among the existing SIG leads.
Such changes should be openly deliberated in advance to ensure inclusivity and maintain community trust.
Please kindly advise how to move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These discussions must take place in a transparent and shared setting (e.g., a group email or slack thread or a SIG leads meeting
just one question as the words open and transparent
may have different interpretation, as someone may imply "fully open" as anybody in the world can access, and other may understand "open to all the leads ONLY", that means is not technicall fully open ... can you clarify? I personally interpret this as "discuss privately with ALL leads involved at the same time"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all for the feedback.
Just to clarify — all SIG leads and etcd maintainers (approvers) reached agreement on the clarification around openness and transparency about two weeks ago, which is why I submitted the PR etcd-io/etcd#20033.
Please let me know if there are concerns about the content itself, or if it's mainly about where this should be documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify — all SIG leads and etcd maintainers (approvers) reached agreement on the clarification around openness and transparency about two weeks ago, which is why I submitted the PR etcd-io/etcd#20033.
As mentioned already several times, sig-etcd being one of k8s sigs has to follow the same processes as all the other sigs. This includes having all of the governance rules specified in this repository, not outside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned already several times, sig-etcd being one of k8s sigs has to follow the same processes as all the other sigs. This includes having all of the governance rules specified in this repository, not outside.
Then the action is to move the https://github.com/etcd-io/etcd/blob/main/GOVERNANCE.md into this repo under sig-etcd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, they should be explicitly pointed out under https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance, not a separate file, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for the clarification.
Updated, PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
to ensure this doesn't merge before final approval from steering
sig-etcd/charter.md
Outdated
@@ -46,8 +46,10 @@ and opts-in to updates and modifications to [sig-governance]. | |||
- Email: [etcd-dev](https://groups.google.com/forum/?hl=en#!forum/etcd-dev). | |||
- Slack: [#etcd](https://kubernetes.slack.com/messages/C3HD8ARJ5/details/) channel on Kubernetes. | |||
- SIG etcd contributing instructions ([CONTRIBUTING.md]) be defined in etcd project. | |||
- SIG etcd governance instructions ([GOVERNANCE.md]) be defined in etcd project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The motivation behind etcd-io/etcd#20033 is to reinforce the importance of open and transparent processes.
I'm not sure what the current document is missing specifically about openness and transparency that you think should be added there. As I'm reading it the process requires to:
- have a discussion both on SIG ML and k8s-dev with information who, why and what
- have time for discussions, including the ability to reach out to steering (even privately, if necessary)
- explicit requirements for new lead.
On top of it has a few handy organizational bits, that people frequently forget to handle while transitioning between leads. But if you think we're missing something I'd like to know what that is.
sig-etcd/charter.md
Outdated
@@ -46,8 +46,10 @@ and opts-in to updates and modifications to [sig-governance]. | |||
- Email: [etcd-dev](https://groups.google.com/forum/?hl=en#!forum/etcd-dev). | |||
- Slack: [#etcd](https://kubernetes.slack.com/messages/C3HD8ARJ5/details/) channel on Kubernetes. | |||
- SIG etcd contributing instructions ([CONTRIBUTING.md]) be defined in etcd project. | |||
- SIG etcd governance instructions ([GOVERNANCE.md]) be defined in etcd project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have SIG governance out of band.
I wholeheartedly agree with Ben on this one 💯
I do not think there is a dual governance model https://github.com/kubernetes/community/blob/master/sig-etcd/charter.md#deviations-from-sig-governance and that looks like an argument for fragmentation for SIGs
... At first sight I prefer am holistic and cohesive model for governance for all sigs
And what Antonio writes as well.
d378bd6
to
6934466
Compare
…adership change Signed-off-by: Benjamin Wang <[email protected]>
6934466
to
7f04901
Compare
Updated this PR per @BenTheElder 's comment etcd-io/etcd#20033 (comment) and @soltysh 's comment #8475 (comment) PTAL, thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/cc @kubernetes/steering-committee
@BenTheElder: GitHub didn't allow me to request PR reviews from the following users: kubernetes/steering-committee. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm Thank you very much @ahrtr for the constructive discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, BenTheElder, fuweid, soltysh, spzala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Update the sig-etcd's
Deviations from [sig-governance]
to link to GOVERNANCE.mdPlease also refer to in etcd-io/etcd#20033.
cc @aojea @BenTheElder @saschagrunert @soltysh @pacoxu @pohly @justaugustus
cc @fuweid @ivanvc @jmhbnz @serathius @siyuanfoundation @spzala @wenjiaswe @jberkus