miner, core, core/txpool: implement EIP 7825 - Transaction Gas Limit Cap #31824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jwasinger wants to merge 5 commits into ethereum:master from jwasinger:eip-7825

+64 −18

Contributor

jwasinger commented May 14, 2025

No description provided.

jwasinger commented

View reviewed changes

core/block_validator.go Outdated Show resolved Hide resolved

jwasinger commented

View reviewed changes

core/txpool/legacypool/legacypool.go Outdated Show resolved Hide resolved

jwasinger commented

View reviewed changes

core/txpool/txpool.go Outdated Show resolved Hide resolved

jwasinger commented

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved

jwasinger commented

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved

jwasinger commented

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved

jwasinger commented

View reviewed changes

core/txpool/legacypool/legacypool.go Outdated Show resolved Hide resolved

MariusVanDerWijden self-assigned this

fjl added the osaka label

fjl mentioned this pull request

Fusaka Fork Planning #31701

Open

12 tasks

jwasinger marked this pull request as ready for review

June 5, 2025 06:32

jwasinger requested review from fjl, karalabe, gballet, rjl493456442, zsfelfoldi and MariusVanDerWijden as code owners

June 5, 2025 06:32

Contributor Author

jwasinger commented Jun 5, 2025 •

edited

Loading

IMO the one thing missing here is test coverage. I'm thinking that some the test coverage will end up in hive tests, and STEEL can probably be responsible for implementing these.

But as this PR is written now, there are edge-cases which probably need to be tested as unit tests: see my comment in miner/worker.go around the non-deterministic order of txpool-reset vs block-construction and how this creates an edge-case on fork boundary.


          core/vm: implement EIP 7825 - Transaction Gas Limit Cap

af879b0

MariusVanDerWijden force-pushed the eip-7825 branch from ea7bbe4 to af879b0 Compare

June 6, 2025 09:46

rjl493456442 reviewed

View reviewed changes

miner/worker.go Outdated Show resolved Hide resolved

rjl493456442 reviewed

View reviewed changes

core/block_validator.go Outdated Show resolved Hide resolved

rjl493456442 and others added 3 commits

June 11, 2025 21:51


          core, miner: polish

e2420ab


          core, miner: add isOsaka field

ccf3020


          remove noop change to legacy pool

aa182ba

rjl493456442 previously approved these changes

View reviewed changes

MariusVanDerWijden previously approved these changes

View reviewed changes

Member

MariusVanDerWijden left a comment

SGTM


          core: move tx gas limit check to state transition

b6256ef

lightclient dismissed stale reviews from MariusVanDerWijden and rjl493456442 via

b6256ef

June 23, 2025 18:00

lightclient self-requested a review as a code owner

June 23, 2025 18:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rjl493456442 rjl493456442 left review comments

MariusVanDerWijden MariusVanDerWijden left review comments

fjl Awaiting requested review from fjl fjl is a code owner

karalabe Awaiting requested review from karalabe karalabe is a code owner

gballet Awaiting requested review from gballet gballet is a code owner

zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

lightclient Awaiting requested review from lightclient lightclient is a code owner

At least 1 approving review is required to merge this pull request.

Labels