fix #7036: Jackson 2.19.0 update issues #7038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1c4r60
commented
Apr 28, 2025
| @@ -475,7 +477,7 @@ void deserializeSetAndReturnWithExceptionAndNullAnySetter() throws IOException { | |||
| class ReflectionTest { | |||
|
|
|||
| @Test | |||
| @DisplayName("all methods from superclass (SettableBeanProperty) are implemented by delegating class (SettableBeanPropertyDelegate)") | |||
There was a problem hiding this comment.
SettableBeanPropertyDelegate does not exist.
r1c4r60
commented
Apr 28, 2025
| @@ -530,5 +540,12 @@ private static MethodSignature from(Method m) { | |||
| return new MethodSignature(m.getReturnType(), m.getName(), m.getParameterTypes()); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Improves how we report findings.
Now:
Note: withSimpleName was just a local test. It wasn't missing.
Previously:
r1c4r60
commented
Apr 28, 2025
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
Note: This @Override is not backward compatible with Jackson versions prior to 2.19.0.
I do have ready local changes using Reflection and package version checks to restore backward compatibility if needed.
r1c4r60
changed the title
r1c4r60
requested review from
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
|
When this is going to land? |
|
@andreaTP Hi 😃 ! |
Closed
…od overrides Refactored ReflectionTest to not only detect but also clearly report missing method implementations in SettableBeanPropertyDelegating. Missing methods are now listed with readable signatures, making similar failures easier to diagnose in the future.
…PropertyDelegating The missing override was detected when upgrading Jackson from 2.18.3 to 2.19.0, where unwrapped(NameTransformer) became a required concrete method.
…ySerializer null errors Fixes an issue in UnmatchedFieldTypeModule where the additionalProperties field was incorrectly wrapped in a BeanPropertyWriterDelegate during serializer construction. This resolves the following test failures: - UnmatchedFieldTypeModuleTest.writeValueAsStringWithAdditionalPropertiesOverridingFields - UnmatchedFieldTypeModuleTest.writeValueAsStringWithAdditionalPropertiesOverridingFieldsShouldLogWarning - UnmatchedFieldTypeModuleTest.writeValueAsStringWithAdditionalPropertiesOverridingFieldsShouldNotLogWarning
The previous check used writer.getName().equals("additionalProperties"),
which failed for variations like getAdditionalProperties or when
@JsonProperty was used.
Changes:
- Skip wrapping the any-getter property in BeanSerializerModifier
- Add isAnyGetterWriter(...) to match the correct property by member
Resolved test failures:
io.fabric8.kubernetes.client.utils.SerializationAdditionalPropertiesTest
- marshalWithAdditionalPropertiesOverridingFields
- cloneShouldPreserveAdditionalProperties
Signed-off-by: Marc Nuri <[email protected]>
…itive) Signed-off-by: Marc Nuri <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
…ted code) Signed-off-by: Marc Nuri <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7036
Supersedes closes #7035
This PR upgrades Jackson from 2.18.3 to 2.19.0 and introduces required changes to align with the stricter API and serialization behavior introduced in the new version.
Key Changes
UnmatchedFieldTypeModule:Updated the
BeanSerializerModifierto correctly skip wrapping the property associated with@JsonAnyGetter(commonlyadditionalProperties) to prevent double-serialization and runtime errors.SettableBeanPropertyDelegating:Implemented the missing
unwrapped(NameTransformer)method to fully comply with theSettableBeanPropertycontract and ensure compatibility with Jackson internals.✅ Resolved Test Failures
io.fabric8.kubernetes.model.jackson.UnmatchedFieldTypeModuleTestwriteValueAsStringWithAdditionalPropertiesOverridingFieldswriteValueAsStringWithAdditionalPropertiesOverridingFieldsShouldLogWarningwriteValueAsStringWithAdditionalPropertiesOverridingFieldsShouldNotLogWarningio.fabric8.kubernetes.model.jackson.SettableBeanPropertyDelegatingTestSettableBeanPropertyDelegatingTest$ReflectionTest.allMethodsFromSuperclassAreImplementedByDelegatingClassio.fabric8.kubernetes.client.utils.SerializationAdditionalPropertiesTestmarshalWithAdditionalPropertiesOverridingFieldscloneShouldPreserveAdditionalPropertiesThis change requires Jackson 2.19.0 or newer.
The updated handling of
@JsonAnyGetterserialization and the completeSettableBeanPropertyimplementation are not backward-compatible with Jackson versions prior to 2.19.0.Type of change
test, version modification, documentation, etc.)
Checklist
Fixes #7035