Skip to content

fix #7036: Jackson 2.19.0 update issues #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
### 7.3-SNAPSHOT

#### Bugs
* Fix #7036: Resolve serialization errors after Jackson 2.19.0 upgrade (breaks older versions)

#### Improvements

Expand All @@ -11,6 +12,7 @@
#### New Features

#### _**Note**_: Breaking changes
* Fix #7036: This release is not backwards-compatible with previous versions of Jackson, you'll need to use Jackson 2.19.0 in your project for a correct behavior of the Kubernetes Client.

### 7.2.0 (2025-04-30)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,11 @@ private T resolveObject(LinkedHashMap<String, String> visited, InternalSchemaSwa
visited = new LinkedHashMap<>();
}

BeanProperty beanProperty = gos.beanProperties.get(property.getKey());
final BeanProperty beanProperty = gos.beanProperties.get(property.getKey());
Utils.checkNotNull(beanProperty, "CRD generation works only with bean properties");
if (beanProperty.getAnnotation(JsonIgnore.class) != null) {
continue;
}

JsonSchema propertySchema = property.getValue();
PropertyMetadata propertyMetadata = new PropertyMetadata(propertySchema, beanProperty);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ public void setUid(String uid) {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ public void setType(String type) {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public void setServiceName(String serviceName) {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonPropertyDescription;
import com.fasterxml.jackson.core.JsonGenerator;
import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.SerializerProvider;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
Expand Down Expand Up @@ -113,7 +112,7 @@ void shouldCreateJsonSchemaFromClass() {
}

@Test
void shouldAugmentPropertiesSchemaFromAnnotations() throws JsonProcessingException {
void shouldAugmentPropertiesSchemaFromAnnotations() {
JSONSchemaProps schema = JsonSchema.from(Annotated.class);
assertNotNull(schema);
Map<String, JSONSchemaProps> properties = assertSchemaHasNumberOfProperties(schema, 2);
Expand Down Expand Up @@ -333,6 +332,7 @@ public static class PreserveUnknown {
private Map<String, Object> values = new HashMap<>();

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.values;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ public void setUid(String uid) {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ public void setType(String type) {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public void setServiceName(String serviceName) {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ public ACMEAuthorizationBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ public ACMEChallengeBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ public ACMEChallengeSolverBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ public ACMEChallengeSolverDNS01Builder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ public ACMEChallengeSolverHTTP01Builder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ public ACMEChallengeSolverHTTP01GatewayHTTPRouteBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ public ACMEChallengeSolverHTTP01IngressBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ public ACMEChallengeSolverHTTP01IngressObjectMetaBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ public ACMEChallengeSolverHTTP01IngressPodObjectMetaBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ public ACMEChallengeSolverHTTP01IngressPodSecurityContextBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ public ACMEChallengeSolverHTTP01IngressPodSpecBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ public ACMEChallengeSolverHTTP01IngressPodTemplateBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ public ACMEChallengeSolverHTTP01IngressTemplateBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public ACMEExternalAccountBindingBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ public ACMEIssuerBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ public ACMEIssuerDNS01ProviderAcmeDNSBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ public ACMEIssuerDNS01ProviderAkamaiBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ public ACMEIssuerDNS01ProviderAzureDNSBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public ACMEIssuerDNS01ProviderCloudDNSBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public ACMEIssuerDNS01ProviderCloudflareBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ public ACMEIssuerDNS01ProviderDigitalOceanBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ public ACMEIssuerDNS01ProviderRFC2136Builder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ public ACMEIssuerDNS01ProviderRoute53Builder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ public ACMEIssuerDNS01ProviderWebhookBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ public ACMEIssuerStatusBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ public AzureManagedIdentityBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ public CertificateDNSNameSelectorBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ public ChallengeBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ public ChallengeListBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ public ChallengeSpecBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ public ChallengeStatusBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ public OrderBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ public OrderListBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ public OrderSpecBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ public OrderStatusBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ public Route53AuthBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ public Route53KubernetesAuthBuilder toBuilder() {
}

@JsonAnyGetter
@JsonIgnore
public Map<String, Object> getAdditionalProperties() {
return this.additionalProperties;
}
Expand Down
Loading
Loading