PB-1615: Fix change form template variable lookup error #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adk-swisstopo
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
https://forum.djangoproject.com/t/proper-way-of-checking-variables-existing-in-templates/25678 suggests there exceptions are routine and best ignored. Without much Django experience I agree it nicer to avoid throwing the exception in the first place.
| @register.simple_tag(takes_context=True) | ||
| def get_context_variable(context, name, default): | ||
| """Retrieve a context variable from the template context, returning a default value if the | ||
| variable is not defined. |
There was a problem hiding this comment.
Please explain in that function documentation why this is useful/needed.
msom
force-pushed
the
bug-PB-1615-property-upload-url
branch
from
f0129b7 to
b8e6b57
Compare
msom
force-pushed
the
bug-PB-1615-property-upload-url
branch
from
b8e6b57 to
daf73d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently overwrite the
change_formtemplate globally and check forproperty_upload_url, which is only defined for a very few admin UI views (and even there only for part of the cases). Although django renders the template without showing an error, it pollutes the logs with a stack trace.This PR introduces a template tag to get the context variable without triggering tracebacks if it is not defined.