Skip to content

PB-1616: Revert "PB-1615: Fix change form template variable lookup error" #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

adk-swisstopo
Copy link
Member

I think https://github.com/geoadmin/infra-kubernetes/pull/801 makes #570 obsolete. So let's revert it.

@adk-swisstopo adk-swisstopo requested a review from msom May 5, 2025 07:34
Copy link
Contributor

@msom msom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's bad practice (and a pain in the a** if you need to debug) to leave unnecessary error messages and stack traces in the log but I don't mind reverting this change.

@adk-swisstopo
Copy link
Member Author

I think it's bad practice (and a pain in the a** if you need to debug) to leave unnecessary error messages and stack traces in the log but I don't mind reverting this change.

I tend to agree but with https://github.com/geoadmin/infra-kubernetes/pull/801 we gave up on that and decided to filter out these messages instead as that's apparently the way to do it in Django. So I think keeping this extra code for nothing is worse.

@adk-swisstopo adk-swisstopo merged commit dc2f371 into develop May 5, 2025
3 checks passed
@adk-swisstopo adk-swisstopo deleted the revert-570-bug-PB-1615-property-upload-url branch May 5, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants