New Release v1.11.0 - #minor #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is to ensure all legacy parameters translate to their current counterparts. The tests do not have to be too thorough, as we are already testing those parameters in their current implementation.
PB-113: small correcton to WMS external legacy test remove comments
…acy and current viewer remove cy call from the should callback removed no longer needed import
PB 113: Legacy test coverage
Added a showtooltip parameter which can be set to 'default', 'fixed', 'floating' or 'none'. Added the url parameter to track it. Modified the Infobox and OpenLayersHighlightedFeatures to use this parameter Removed the old 'floatingTooltip' parameter
PB-190: renaming keys to pass the check in setFeatureInfoPosition PB-190: last nomenclature changes PB-190: nomenclature harmonization small nomenclature change small rebase artifacts accidentally made both the combo and the tooltip show use v-show instead of v-if in Infobox module for the infobox-content container
…d using a better computed getter in cesium map for tooltip position
PB-190 : small bugfixes dispatcher fix nomenclature harmonization
PB 190 : alter tooltip position behaviour
The store crashed, because when toggling to 2d we need to set the camera position to null as in 2d we don't have a camera.
This is a preparation work to allow to add the basic map tools to the embed vue, therefore remove it from the menu module and put it to the map module. Those tools are anyway more some basic map tools that should be part of the map module, and we keep the menu module for more advanced stuff. Also made the map tool box with slot extensible.
…om windows.location To avoid issue parsing a second time the query from the url, use it from the vue router. Note that now we have more than one route and that the hash is not always #/map but can be something else like #/embed
The util getUrlQuery() was buggy has it worked only if the hash was #/map but now we have several views e.g. #/embed. Therefore remove this util and use the router instead.
This ease the debugging of flaky cypress drawing tests
Somehow this test failed when using the data-cy=map, the pointer event was never fired even though we waited for the pointer event to be set. It seems that using the ol-map instead solved the issue. NOTE: the issue was only on the CI !
- Added a way to wait for the map pointer event listener to be set - Added more logs to ease the debugging of flaky e2e tests - Fix drawing flaky test which used the cy.readStoreValue() with then(), in this case there is no retries and it might time to time failed, now we use window.its().should() which based on the cypress documentation should retry until the assertion is true.
PB-317: Added basic toolbox to embed (zoom buttons)
Use the same style as for the other menu list items.
PB-315: Normalized the share embed button
In 3d we cannot use the openlayer compass
PB-315: Fix crash when toggling into 3d mode
The legacy embed view was at hostname/embed.html. Unfortunately we cannot reroute here to another path before the #, because the vue router using the createWebHashHistory can only handle route after the hash. Therefore we have an external redirect service that will redirect to /embed.html to ?legacyEmbed. We use this pseudo legacyEmbed to redirect to #/embed once the other legacy parameters have been translated.
PB-315: Handle legacy embed view
…_shift_select PB-325: Add styling to openlayers drag zoom
PB-315: Normalized the toolbox right tooltips
In most of the code, we are using camelCase for our parameters and variables The compare slider was using snake_case. We are now using camelCase for the compareRatio parameter, and the compareSlider data-cy
Compare Ratio Case Change
Make more sense to use the tippy default placement in the composable as using the one needed for the toolbox.
Let the tippy placement default for the composable
Passing run #1121 ↗︎
Details:
Review all test suite changes for PR #710 ↗︎ |
|||||||||||||||
LukasJoss
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link