Setting new target for test binaries #2244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Programs in the tests directory are now build with target tests and placed in the same location. * clean target was expanded to remove new binaries * test target binaries are listed in a variable * Locations of binaries were added to the .gitignore Signed-off-by: Jiri Podivin <[email protected]>
|
Alternatively they can be deleted instead. |
ggerganov
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original run-tests.sh script no longer exists and the sources for tests are not considered by the makefile. #2243
This change removes the old reference and creates build targets for contents of the tests dir.
Since these are one purpose test utilities, I have decided to leave them in their original location, that is the tests dir,
rather than have them on the top level. Alternatively they could get into special subdir. But that's up for debate.
I've tested some of the newly build utils, and they appear to work. There no build errors, only a handful of warnings.
Programs in the tests directory are now build with target tests and placed in the same location.
clean target was expanded to remove new binaries
test target binaries are listed in a variable
Locations of binaries were added to the .gitignore