Skip to content

Add golangci-lint #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 20, 2019
Merged

Add golangci-lint #192

merged 8 commits into from
Mar 20, 2019

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 29, 2018

Closes #162.

@AlekSi AlekSi force-pushed the add-golangci-lint branch from 1e89e51 to 44fd84c Compare March 20, 2019 04:50
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #192 into v1-stable will decrease coverage by 2.55%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           v1-stable     #192      +/-   ##
=============================================
- Coverage      68.49%   65.94%   -2.56%     
=============================================
  Files             19       19              
  Lines           1565     1565              
=============================================
- Hits            1072     1032      -40     
- Misses           443      480      +37     
- Partials          50       53       +3
Impacted Files Coverage Δ
reform-db/cmd_init_mssql.go 0% <0%> (-34.49%) ⬇️
reform-db/cmd_init_mysql.go 0% <0%> (-32.26%) ⬇️
reform-db/models.go 64.7% <0%> (-11.77%) ⬇️
reform-db/cmd_init.go 62.35% <0%> (-7.06%) ⬇️
querier_selects.go 94.78% <0%> (-2.61%) ⬇️
querier_commands.go 80.8% <0%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e802f...190a60a. Read the comment docs.

@AlekSi AlekSi changed the title [WIP] Add golangci-lint Add golangci-lint Mar 20, 2019
@AlekSi AlekSi self-assigned this Mar 20, 2019
@AlekSi AlekSi added this to the v1.4.0 milestone Mar 20, 2019
@AlekSi AlekSi merged commit ab7a8ce into v1-stable Mar 20, 2019
@AlekSi AlekSi deleted the add-golangci-lint branch March 20, 2019 05:34
@AlekSi AlekSi added the chore label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants