Removed unnecessary check for name in spanner database post_create #9817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…13695) [upstream:07c000c081f1502692168134ffdacf2860592814] Signed-off-by: Modular Magician <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spanner database. post_create relied specifically on accessing opRes, but name is actually a settable & required field on that resource so it's not necessary to pull it from the operation as far as I can tell.
This code will stop working as a consequence of changes for hashicorp/terraform-provider-google#22214, because this resource will no longer be detected as requiring opRes to be set (because there are no computed fields that need to be set after create.)
This part of the post_create template was added in this commit, after this round of review. I don't see anything indicating that this was added in response to a specific problem, and
nameshould always be available anyway (because it's a required field) so I think this may have been a mistake.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Derived from GoogleCloudPlatform/magic-modules#13695