Skip to content

make it clear that the attribute represents the project id #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2018
Merged

make it clear that the attribute represents the project id #672

merged 3 commits into from
Mar 12, 2018

Conversation

topliceanu
Copy link
Contributor

Projects in GCP have an id, a name and a project_number. All seem to uniquely identify your project. In this case it is the id that is required.

Projects in GCP have an id, a name and a project_number. All seem to uniquely identify your project. In this case it is the `id` that is required.
@eilgin
Copy link
Contributor

eilgin commented Nov 6, 2017

Wouldn't have it been better to say "The project id [...]" ?
Besides, it's not the only time when the doc refers to "project" when describing the project id.

@topliceanu
Copy link
Contributor Author

I see, that is a good point. I'll scan the doc and see where I can find project being used instead of
"project id". Thanks for getting back to me!

@paddycarver paddycarver self-requested a review November 7, 2017 23:14
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board with this, though I think it may have some confusion (e.g., people thinking it's the project number) but that's not something we can really help, I don't think. Only nitpick: ID, not id. :)

@topliceanu
Copy link
Contributor Author

topliceanu commented Nov 14, 2017

Hi guys! Sorry about being late with this. I went through the docs and updated the resources.

I went with the ID of the project .... Event though it sounds a bit forced, I think it makes more sense than Project ID ... for most of the sentences. That being said, not a native speaker here.

Also, I haven't actually checked whether all these resource actually use the value of the project attribute as the Project ID, but I assume so, if they didn't it would be terribly inconsistent. How can I test this?

Let me know how I can improve this PR! Thanks!

@nat-henderson nat-henderson merged commit 7e64b3f into hashicorp:master Mar 12, 2018
@topliceanu topliceanu deleted the patch-1 branch March 16, 2018 08:07
ashish-amarnath pushed a commit to ashish-amarnath/terraform-provider-google that referenced this pull request Mar 20, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants