-
Notifications
You must be signed in to change notification settings - Fork 1.8k
make it clear that the attribute represents the project id #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Projects in GCP have an id, a name and a project_number. All seem to uniquely identify your project. In this case it is the `id` that is required.
Wouldn't have it been better to say "The project id [...]" ? |
I see, that is a good point. I'll scan the doc and see where I can find |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on board with this, though I think it may have some confusion (e.g., people thinking it's the project number) but that's not something we can really help, I don't think. Only nitpick: ID, not id. :)
…rs to the `Project ID` and not it's name.
Hi guys! Sorry about being late with this. I went through the docs and updated the resources. I went with Also, I haven't actually checked whether all these resource actually use the value of the Let me know how I can improve this PR! Thanks! |
Signed-off-by: Modular Magician <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Projects in GCP have an id, a name and a project_number. All seem to uniquely identify your project. In this case it is the
id
that is required.