Skip to content

set irq priority for freertos #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022

Conversation

ccrome
Copy link
Contributor

@ccrome ccrome commented May 5, 2022

Describe the PR
For FreeRTOS, This PR sets the USB interrupt priority to configLIBRARY_MAX_SYSCALL_INTERRUPT_PRIORITY, which is where it should be in order to not cause problems for freeRTOS. it was initially there, then commented out for some reason. Not sure exactly why it was removed.

This sets the interrupt priority for both USB ports, if they exist.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Can you put the code directly into the #elif instead of having an extra function.

@ccrome ccrome force-pushed the chc-fix-freertos-irq-imx branch from e6d04ed to f65d7d0 Compare May 6, 2022 05:27
@ccrome
Copy link
Contributor Author

ccrome commented May 6, 2022

sure, no problem. Just commited. Is the right thing here to do a force-push so there's only one commit? That's what I did.

@ccrome ccrome force-pushed the chc-fix-freertos-irq-imx branch from f65d7d0 to f19d913 Compare May 6, 2022 05:29
Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look great, thank you for your PR. This indeed should be set by all ports with freeRTOS.

@hathach hathach merged commit d23c9b7 into hathach:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants