fix: 18795: HDHM repair mechanism can be improved to clean stale buckets (#18796)

Fixes: #18795
Reviewed-by: Anthony Petrov <[email protected]>, Ivan Malygin <[email protected]>, Nikita Lebedev <[email protected]>
Signed-off-by: Artem Ananev <[email protected]>

Author: artemananiev

platform-sdk/swirlds-merkledb/src/main/java/com/swirlds/merkledb/files/hashmap/HalfDiskHashMap.java

@@ -333,19 +333,26 @@ public void repair(final long firstLeafPath, final long lastLeafPath, final Memo
             }
             try (final ParsedBucket bucket = new ParsedBucket()) {
                 bucket.readFrom(bucketData);
+                if (bucket.getBucketIndex() != bucketId) {
+                    logger.warn(MERKLE_DB.getMarker(), "Delete bucket (stale): {}", bucketId);
+                    bucketIndexToBucketLocation.remove(bucketId);
+                    continue;
+                }
                 bucket.forEachEntry(entry -> {
                     final Bytes keyBytes = entry.getKeyBytes();
                     final long path = entry.getValue();
                     try {
                         boolean removeKey = true;
                         if ((path < firstLeafPath) || (path > lastLeafPath)) {
-                            logger.warn("Delete key (path range): key={}, path={}", keyBytes, path);
+                            logger.warn(
+                                    MERKLE_DB.getMarker(), "Delete key (path range): key={}, path={}", keyBytes, path);
                         } else {
                             final BufferedData recordBytes = store.get(path);
                             assert recordBytes != null;
                             final VirtualLeafBytes record = VirtualLeafBytes.parseFrom(recordBytes);
                             if (!record.keyBytes().equals(keyBytes)) {
                                 logger.warn(
+                                        MERKLE_DB.getMarker(),
                                         "Delete key (stale): path={}, expected={}, actual={}",
                                         path,
                                         record.keyBytes(),