Skip to content

HDHM repair mechanism can be improved to clean stale buckets #18795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artemananiev opened this issue Apr 10, 2025 · 0 comments · Fixed by #18796
Closed

HDHM repair mechanism can be improved to clean stale buckets #18795

artemananiev opened this issue Apr 10, 2025 · 0 comments · Fixed by #18796
Assignees
Labels
Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform Stability Tickets pertaining to the stability of the consensus node.
Milestone

Comments

@artemananiev
Copy link
Contributor

HDHM repair mechanism introduced in #18593 can be improved further. What it currently does it iterates over all buckets and all bucket entries and compares them with data from path to KV store. If a key entry doesn't match, it's removed from HDHM. In addition to that, we can also check bucket indices to make sure bucket index is not corrupted, i.e. an index entry pointing to bucket data location, where a bucket with a different ID is located. There should be no such buckets, but there have been bugs recently that could result in index corruption. See #18235 for details.

@artemananiev artemananiev added Platform Tickets pertaining to the platform Platform Data Structures Platform Virtual Map Stability Tickets pertaining to the stability of the consensus node. labels Apr 10, 2025
@artemananiev artemananiev added this to the v0.62 milestone Apr 10, 2025
@artemananiev artemananiev self-assigned this Apr 10, 2025
@artemananiev artemananiev moved this to 🛠 In Progress in Foundation Team Apr 10, 2025
@artemananiev artemananiev moved this from 🛠 In Progress to 👀 In Review in Foundation Team Apr 10, 2025
@artemananiev artemananiev moved this from 👀 In Review to ✅ Done in Foundation Team Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform Stability Tickets pertaining to the stability of the consensus node.
Projects
Status: ✅ Done
1 participant