fix: 18795: HDHM repair mechanism can be improved to clean stale buckets #18796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Ananev <[email protected]>
artemananiev
added
Platform Virtual Map
Platform Data Structures
Platform
imalygin
approved these changes
Apr 10, 2025
anthony-swirldslabs
approved these changes
Apr 10, 2025
thenswan
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix summary:
HDHM.repair()is improved to check bucket ID integrity. That is, when a bucket is loaded for a bucket ID, this bucket's ID is checked against the ID from the index. If they don't match, the bucket is removed altogether from the indexFixes: #18795
Signed-off-by: Artem Ananev [email protected]