-
Notifications
You must be signed in to change notification settings - Fork 299
docs(examples): add authN/authZ for supply chain app example #1579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
add token to apiClient.ofLedger and PluginConsortiumManual getConsortiumJws method when property is setted relationed with hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
relationed with hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
relationed with hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
relationed with hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
relationed with hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
relationed with #1579 Signed-off-by: Elena Izaguirre <[email protected]>
relationed with hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]> Signed-off-by: aldousalvarez <[email protected]>
relationed with hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]> Signed-off-by: aldousalvarez <[email protected]>
@petermetz In point 5 of Acceptance Criteria you say "Publish the container image to GHCR" but I cannot do it before merge changes because I need the npm version, so I think the right order is this:
|
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
@elenaizaguirre Oops, you are right. We can break this issue down into two separate ones to model the reality of the dependent steps. Could you create that other issue and move the container image publishing criteria over to that one from this one? |
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]>
1. The JWT token to be used is printed by the Supply Chain App after it successfully bootstrapped itself (pulled up the ledgers, API server) 2. The web application uses a native window prompt for getting the token which might need to be refactored in the future because there are ideas floating around on the internet that the window prompt/alert APIs should be discontinued in web browsers altogether. 3. The image built from this source code has been pushed to ghcr.io as: ghcr.io/hyperledger/cactus-example-supply-chain-app:2022-04-05--feat-1579 closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
1. The JWT token to be used is printed by the Supply Chain App after it successfully bootstrapped itself (pulled up the ledgers, API server) 2. The web application uses a native window prompt for getting the token which might need to be refactored in the future because there are ideas floating around on the internet that the window prompt/alert APIs should be discontinued in web browsers altogether. 3. The image built from this source code has been pushed to ghcr.io as: ghcr.io/hyperledger/cactus-example-supply-chain-app:2022-04-05--feat-1579 closes #1579 Signed-off-by: Elena Izaguirre <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
1. The JWT token to be used is printed by the Supply Chain App after it successfully bootstrapped itself (pulled up the ledgers, API server) 2. The web application uses a native window prompt for getting the token which might need to be refactored in the future because there are ideas floating around on the internet that the window prompt/alert APIs should be discontinued in web browsers altogether. 3. The image built from this source code has been pushed to ghcr.io as: ghcr.io/hyperledger/cactus-example-supply-chain-app:2022-04-05--feat-1579 closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
Description
We want to be reasonably sure that we haven't forgotten anything basic from the JWT support code in the API server and the best way to find out is to try and make one of the end to end examples work with JWT authorization so that we can put ourselves in the shoves of someone who is developing an application with the framework leveraging the plugins and the API server.
While doing the above, likely some issues will come to light that otherwise would've been hidden until we go to 1.0.0 and people start using it so this way we can get ahead of that.
If any issues arise, please make sure to create new, separate tasks for fixing those that can also be addressed by separate PRs so that we avoid one huge PR that updates the examples and also updates core/API-server/core-api package code at the same time.
By the end of it in the PR resolving this issue we should only have the changes that are touching only the examples folder code because everything else necessary (prerequisites) was done already.
Acceptance Criteria
Publish the container image to GHCR and also make sure to update the root README.md and the inner supply-chain-app README.md with those images.This part will be done in issue docs(examples): update container image for supply chain #1815The text was updated successfully, but these errors were encountered: