-
Notifications
You must be signed in to change notification settings - Fork 299
feat: add jwt authorization to supply chain example #1801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add jwt authorization to supply chain example #1801
Conversation
0a8f83b
to
b403bfa
Compare
f642c23
to
c099442
Compare
c099442
to
cc0ab56
Compare
cc0ab56
to
62c7e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petermetz As we talked about here, I need the newest npm packages before create the image
@elenaizaguirre Ah, I'm so sorry, I'm struggling to keep up with everything... :-)
I just published your branch to npm with these package names (pasted below).
Does this make it possible now to build and publish the docker image so that the tag in the readme can also be updated? I'm pushing for this because if we merge this PR as-is then the instructions in the README will get updated, but without the new image the new instructions won't make sense to people so I opted to eliminate the deadlock by publishing the npm packages as a canary release. Sorry again for all this back and forth and the complications. Release management is not easy due to the dependencies unfortunately.
Successfully published:
- @hyperledger/cactus-example-carbon-accounting-backend@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-example-carbon-accounting-business-logic-plugin@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-example-carbon-accounting-frontend@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-example-supply-chain-backend@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-example-supply-chain-business-logic-plugin@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-example-supply-chain-frontend@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-htlc-coordinator-besu@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-object-store-ipfs@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/cactus-plugin-consortium-manual@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-htlc-eth-besu-erc20@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/cactus-plugin-keychain-azure-kv@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-keychain-google-sm@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-keychain-memory-wasm@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-besu@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-corda@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-fabric-socketio@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-fabric@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-go-ethereum-socketio@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-iroha@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-quorum@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-sawtooth-socketio@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-plugin-ledger-connector-xdai@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/[email protected]+62c7e930
- @hyperledger/cactus-test-plugin-consortium-manual@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-test-plugin-htlc-eth-besu-erc20@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-test-plugin-htlc-eth-besu@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-test-plugin-ledger-connector-besu@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/cactus-test-plugin-ledger-connector-quorum@1.0.0-jwt-supply-chain.62c7e930.0+62c7e930
- @hyperledger/[email protected]+62c7e930
@petermetz Don't worry, I know you are very busy and I am very grateful for your help. Regarding the npm packages, I think something went wrong. When I install I checked several package.json of the container but only |
8e68bb4
to
0df4510
Compare
0df4510
to
b9382d5
Compare
1. The JWT token to be used is printed by the Supply Chain App after it successfully bootstrapped itself (pulled up the ledgers, API server) 2. The web application uses a native window prompt for getting the token which might need to be refactored in the future because there are ideas floating around on the internet that the window prompt/alert APIs should be discontinued in web browsers altogether. 3. The image built from this source code has been pushed to ghcr.io as: ghcr.io/hyperledger/cactus-example-supply-chain-app:2022-04-05--feat-1579 closes hyperledger-cacti#1579 Signed-off-by: Elena Izaguirre <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
b9382d5
to
ca29240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elenaizaguirre Very sorry for the slow turnaround I finally managed to get this over the finish line.
Published the image with the freshly published canary npm packages as ghcr.io/hyperledger/cactus-example-supply-chain-app:2022-04-05--feat-1579
and updated your PR so that the README files point to this one as well.
LGTM
closes #1579
Signed-off-by: Elena Izaguirre [email protected]