Update broker API package. #334
Conversation
xiaolanz
requested review from
douglas-reid,
geeknoid and
rshriram
as code owners
googlebot
added
the
cla: yes
|
this is in @geeknoid 's territory |
There was a problem hiding this comment.
Considering this functionality is not really ready for use in any way, I think v1alpha is inappropriate. Let's mark it as "dev" instead.
Also, please add a single-line comment on top of every type that says
// $hide_from_docs
This will prevent these types from being listed in our reference docs on istio.io.
|
PTAL. I think all these message should be included in the doc. |
|
The point of $hide_docs is to hide them from our current doc set. These
features are not ready for anybody to use and showing them in our reference
docs on istio.io is misleading for our customers.
When the feature is ready for use, then $hide_from_docs can be removed at
that point.
…On Wed, Jan 31, 2018 at 11:36 AM, Joy Zhang ***@***.***> wrote:
PTAL. I think all these message should be included in the doc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#334 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVucHTwVG9NcJIOFcE9P5Yq-XSIE-Iirks5tQMDMgaJpZM4RzP2B>
.
|
|
@xiaolanz This change is not backward compatible and it breaks istio/istio when we try to pick up the latest version of the api. Please fix istio/istio or revert this PR. |
|
yes. I'm aware of that. i'm working on fixing istio/istio. What's the current process of picking up new api versions? |
|
@xiaolanz you have to change revision number for istio/api in Gopkg.toml and run dep ensure -update. |
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
* start waf * add validation * refactor firewall settings to waf settings in tsb 1.4 (istio#334) * refactor firewall settings to waf settings in tsb 1.4 * lint * lint * rename rule_set to rule_sets(comply with 1.5 api) and add rule engine example * refactor according to comments * add more detailed example * remove unneeded example * fix missing body Co-authored-by: arifsetiawan <[email protected]> Co-authored-by: zhihanz <[email protected]> Co-authored-by: Christoph Pakulski <[email protected]>
Update into broker.dev and follow api style guidelines.
istio/istio#3457