-
-
Notifications
You must be signed in to change notification settings - Fork 332
[iOS & tvOS] Upgrade SDK to 10.10 #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update README to use 10.10.6. Bumped up from 10.8.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting in some comments to get ahead of potential questions/reasons.
Shared/Extensions/JellyfinAPI/MediaSourceInfo/MediaSourceInfo+ItemVideoPlayerViewModel.swift
Show resolved
Hide resolved
Swiftfin.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
...shboardView/ServerDevices/DeviceDetailsView/Components/Sections/CompatibilitiesSection.swift
Show resolved
Hide resolved
...hboardView/ServerDevices/DeviceDetailsView/Components/Sections/CustomDeviceNameSection.swift
Show resolved
Hide resolved
...ettings/ServerUserAccessTags/EditServerUserAccessTagsView/EditServerUserAccessTagsView.swift
Outdated
Show resolved
Hide resolved
...ers/ServerUserSettings/ServerUserPermissionsView/Components/Sections/ManagementSection.swift
Outdated
Show resolved
Hide resolved
I can't remember if there were any actual issues that caused me to close #1072, but if there aren't any regressions this can go in 1.3. |
Not that I'm aware of lol. That being said, my reasoning for 1.4 is that I don't know how much longer we want to keep the on TestFlight for 1.3 going. I'd hate to have some critical Live TV bug or something that is floating around in 10.10 for us that I missed because I don't have Live TV configured or something like that. Last revision in. I was just thinking about the This should be ready again for a review! |
I'm not that concerned that 1.3 has been in TestFlight for as long as it has, at least not as much as I was at first. Since we're dropping iOS 15, putting in as many bug fixes would be desirable. We can still have bug fixes for iOS 15 in 1.3.x updates after dropping support by working in a separate branch, but I want to keep any fixes that could potentially happen to a minimum. |
Okay one more change. I didn't realize you started this in #1072 so I took a look a this. I preferred how you were using Unless you see anything, I think that moves me to only 2 outstanding questions:
Unofficial 3), |
Resolved: // TODO: 10.10 - Filter to only valid SortBy's for each BaseItemKind. Last outstanding item: // TODO: 10.10 - What should authenticationProviderID & passwordResetProviderID be?
The route I took was using:
The For this reason, I chose to go the If this is correct, 10.10 should be ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
We will have to revisit the addition of |
Summary
Indirectly resolves: #1289 & #1293
This PR serves as a starting point to migrate us from the current 10.8 SDK to 10.10. No actual 10.10 features are added except for the previously built and commented out
DeviceDetailsView
&AccessTags
items that were already built in preparation for 10.10.Other than those 2 views, everything else is just a 1:1 update to get everything working and buildable on 10.10. I am using my own branch for the 10.10 SDK but I have a pull request to hopefully get that in here.
This PR should serve as a good starting point but we likely need to knock out some TODOs first.
TODOs
TODO: 10.10 -
. None of these are preventing building nor do they causes any issues in initial testing but they should be resolved first. These primarily have to do with the new init forUserPolicy
so it should be very very quick.