Stateful - Set cleanup and final classes
#1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPKribs
added
enhancement
JPKribs
added a commit
to JPKribs/Swiftfin
that referenced
this pull request
Mar 30, 2025
LePips
added a commit
that referenced
this pull request
Apr 7, 2025
* Buildable! * Update file names. * Default sort to sort name NOT name. * SessionInfoDto vs SessionInfo * Targetting * Fix many invalid `ItemSortBy` existing. Will need to revisit later to see which can still be used! * ExtraTypes Patch. * Move from Binding to OnChange. Tested and Working. * Update README.md Update README to use 10.10.6. Bumped up from 10.8.13 * Update to Main on https://github.com/jellyfin/jellyfin-sdk-swift.git * Now using https://github.com/jellyfin/jellyfin-sdk-swift.git again! * Paths.getUserViews() userId moved to parameters * Fix ViewModels where -Dto suffixes were removed by #1465 auto-merge. * SupportedCaseIterable * tvOS supportedCases fixes for build issue. * cleanup * update API to 0.5.1 and correct VideoRangeTypes. * Remove deviceProfile.responseProfiles = videoPlayer.responseProfiles * Second to last adjustment: Resolved: // TODO: 10.10 - Filter to only valid SortBy's for each BaseItemKind. Last outstanding item: // TODO: 10.10 - What should authenticationProviderID & passwordResetProviderID be? * Trailers itemID must precede userID * Force User Policy to exist. --------- Co-authored-by: Ethan Pippin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1203 I've been needing to remove
lastActionand have been meaning to do some other cleanup withStateful, as well as making the necessary view modelsfinaland removingfinalfrom stored variables as they aren't necessary.