Use f-strings where pyupgrade doesn't handle it automatically #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/f-strings
branch
from
f68e27b to
f2725f2
Compare
7 tasks
manics
reviewed
Sep 22, 2021
There was a problem hiding this comment.
Can you revert the change to binderhub/_version.py (as discussed in #1381 (comment))
Otherwise this looks fine.
consideRatio
force-pushed
the
pr/f-strings
branch
from
f2725f2 to
d5d26aa
Compare
|
Ah, I were only on the lookout for versioneer.py - thanks! Done! |
manics
approved these changes
Sep 22, 2021
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Sep 22, 2021
jupyterhub/binderhub#1387 Merge pull request #1387 from consideRatio/pr/f-strings
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1381 as manual transformations that pyupgrade failed to make automatically.