Skip to content

Add agent_id label to containers #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2023

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented May 6, 2023

resolves #875

@fregataa fregataa added this to the 23.03 milestone May 6, 2023
@fregataa fregataa self-assigned this May 6, 2023
@github-actions github-actions bot added comp:agent Related to Agent component type:feature Add new features size:S 10~30 LoC labels May 6, 2023
@fregataa fregataa requested a review from achimnol May 6, 2023 05:23
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to consider the container's ai.backend.owner labels when scanning contaienrs in the agents.

@fregataa
Copy link
Member Author

fregataa commented May 6, 2023

I think we also need to consider the container's ai.backend.owner labels when scanning contaienrs in the agents.

When scanning containers, should I sync kernel_registry by creating missing kernel object or just skip other's kernel object, or do both?

I let agent check container's owner id and update own container's kernel when scanning containers.

@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels May 6, 2023
@fregataa fregataa requested a review from achimnol May 6, 2023 10:57
@achimnol achimnol enabled auto-merge May 8, 2023 08:32
@achimnol achimnol added this pull request to the merge queue May 8, 2023
Merged via the queue into main with commit 966c739 May 8, 2023
@achimnol achimnol deleted the feature/container-label-assigned-agent-id branch May 8, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component size:M 30~100 LoC type:feature Add new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish which agent instance owns a running kernel container
2 participants