fix(BA-1626): Improve logging for inspecting missing containers #4784
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors error handling and logging in the Docker agent to improve readability and clarity when handling missing or cleaned containers.
- Replaces hardcoded HTTP status codes with HTTPStatus enumerations.
- Adjusts logging behavior for better clarity on Docker error events.
.fix.md -> 4784.fix.md Co-authored-by: octodog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1266 and resolves #4783 (BA-1626)
This pull request refactors error handling in the
src/ai/backend/agent/docker/agent.pyfile by replacing hardcoded HTTP status codes with theHTTPStatusenumeration for improved readability and maintainability. Additionally, logging behavior has been adjusted to ensure better clarity when handling specific Docker errors.Refactoring HTTP status codes:
src/ai/backend/agent/docker/agent.py: Replaced hardcoded HTTP status codes (404and409) withHTTPStatus.NOT_FOUNDandHTTPStatus.CONFLICTin multiple methods (_fetch_container_info,check_image,destroy_kernel, andlog_iter). This improves code readability and aligns with Python's standard library conventions. [1] [2] [3] [4] [5]Logging enhancements:
src/ai/backend/agent/docker/agent.py: Adjusted logging behavior in error handling to provide clearer warnings when Docker errors occur, such as containers not found or already cleaned. [1] [2] [3]Checklist: (if applicable)