Skip to content

xkb: implement VoidAction #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

xkb: implement VoidAction #45

wants to merge 1 commit into from

Conversation

mahkoh
Copy link
Owner

@mahkoh mahkoh commented May 9, 2025

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for VoidAction in the xkb processing by introducing a new ResolvedVoidAction type and integrating it across the xkb action evaluation and diagnostic systems. Key changes include:

  • Adding the ResolvedVoidAction struct and enum variant in kbvm/src/xkb/resolved.rs.
  • Updating generated meanings, diagnostics, and error handling to accommodate VoidAction.
  • Mapping ResolvedVoidAction in action processing and adding associated test cases.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
kbvm/src/xkb/resolved.rs Adds ResolvedVoidAction field in ActionDefaults and a new enum variant in ResolvedAction.
kbvm/src/xkb/meaning/generated.rs Introduces a new Meaning variant for VoidAction and updates mappings accordingly.
kbvm/src/xkb/keymap/from_resolved.rs Maps ResolvedVoidAction to an Action using a ControlsLock with default values.
kbvm/src/xkb/kccgst/expr.rs Adds EvalError and ActionParameters implementation for VoidAction.
kbvm/src/xkb/diagnostic.rs Adds a new diagnostic variant and example for UnknownParameterForVoidAction.
generator/src/xkb.rs Updates string array and constant length to include VoidAction.
compile-tests/…/input.xkb & expected.xkb Adds a test case for a key with a VoidAction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant