actions: Add VoidAction(), mirroring NoSymbol/VoidSymbol. #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
the
compile-keymap
mahkoh
reviewed
May 9, 2025
| It enables erasing a previous action and breaks latches. | ||
|
|
||
| This is a libxkbcommon extension. When serializing it will be converted to | ||
| `LockControls(controls=none,affect=neither)` for backward compatibility. |
There was a problem hiding this comment.
Does LockControls also break latches?
There was a problem hiding this comment.
It does. See also our own xkb_action_breaks_latch().
There was a problem hiding this comment.
In that case, AIUI, VoidAction is just a nicer alias for the LockControls action. If so, this LGTM.
There was a problem hiding this comment.
Exactly. This brings better semantics and we can make it a proper independent action later. I chose LockControls(controls=none,affect=neither) because it seems the only portable action we support that would cause no side effect other than breaking latches. SetControls() may be fine too, but the affect=neither field of LockControls seems to better ensure it is a dummy action.
Added `VoidAction()` action to match the keysym pair `NoSymbol` / `VoidSymbol`. It enables erasing a previous action and breaks latches. This is a libxkbcommon extension. When serializing it will be converted to `LockControls(controls=none,affect=neither)` for backward compatibility. We cannot serialize it to `NoAction()`, as it would be dropped in e.g. the context of multiple actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
VoidAction()action to match the keysym pairNoSymbol/VoidSymbol.It enables erasing a previous action and breaks latches.
This is a libxkbcommon extension. When serializing it will be converted to
LockControls(controls=none,affect=neither)for backward compatibility. We cannot serialize it toNoAction(), as it would be dropped in e.g. the context of multiple actions.Fixes #622
@mahkoh @Jules-Bertholet