Skip to content

Add property to restrict approver from approving their own run #20593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add property to restrict approver from approving their own run #20593

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98d9ef2
add property to restrict approver from approving their own run
v-gayatrij Oct 25, 2024
4eb9efa
Merge branch 'master' into users/v-gayjaiswal/MV-restrict-requestor
v-gayatrij Nov 1, 2024
dea174c
Merge branch 'master' into users/v-gayjaiswal/MV-restrict-requestor
v-gayatrij Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Tasks/ManualValidationV1/Strings/resources.resjson/en-US/resources.resjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"loc.input.help.notifyUsers": "Send a manual validation pending email to specific users (or groups). Only users specified in approvers can act on a manual validation.",
"loc.input.label.approvers": "Approvers",
"loc.input.help.approvers": "Specify users/groups/project teams separated by commas to act on a manual validation. In absence of input, users with queue build permission will be able to take action.",
"loc.input.label.allowApproversToApproveTheirOwnRuns": "Allow approvers to approve their own run",
"loc.input.help.allowApproversToApproveTheirOwnRuns": "If this is true, approver will be able to approve their own run",
"loc.input.label.instructions": "Instructions",
"loc.input.help.instructions": "These instructions will be shown to the user for resuming or rejecting the manual validation. Based on these instructions the user will take an informed decision about this manual validation.",
"loc.input.label.onTimeout": "On timeout",
Expand Down
10 changes: 9 additions & 1 deletion Tasks/ManualValidationV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"version": {
"Major": 1,
"Minor": 244,
"Minor": 248,
"Patch": 0
},
"inputs": [
Expand All @@ -35,6 +35,14 @@
"required": false,
"helpMarkDown": "Specify users/groups/project teams separated by commas to act on a manual validation. In absence of input, users with queue build permission will be able to take action."
},
{
"name": "allowApproversToApproveTheirOwnRuns",
"type": "boolean",
"label": "Allow approvers to approve their own run",
"required": false,
"defaultValue": "false",
"helpMarkDown": "If this is true, approver will be able to approve their own run"
},
{
"name": "instructions",
"type": "multiLine",
Expand Down
10 changes: 9 additions & 1 deletion Tasks/ManualValidationV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"version": {
"Major": 1,
"Minor": 244,
"Minor": 248,
"Patch": 0
},
"inputs": [
Expand All @@ -35,6 +35,14 @@
"required": false,
"helpMarkDown": "ms-resource:loc.input.help.approvers"
},
{
"name": "allowApproversToApproveTheirOwnRuns",
"type": "boolean",
"label": "ms-resource:loc.input.label.allowApproversToApproveTheirOwnRuns",
"required": false,
"defaultValue": "false",
"helpMarkDown": "ms-resource:loc.input.help.allowApproversToApproveTheirOwnRuns"
},
{
"name": "instructions",
"type": "multiLine",
Expand Down
Loading