Implement accessibilityState #4617
Conversation
|
Could we split this into two changes? We want to backport accessibilityState to 0.61, but don't want to remove accessibilityStates from that branch? #Resolved |
| @@ -140,7 +140,6 @@ const ReactNativeViewConfig = { | |||
| accessibilityLabel: true, | |||
| accessibilityLiveRegion: true, | |||
| accessibilityRole: true, | |||
| accessibilityStates: true, // TODO: Can be removed after next release | |||
There was a problem hiding this comment.
This and the comment were stock 0.62. We should probably leave this as is. #Resolved
There was a problem hiding this comment.
This is weird - I don't see any mention of accessibilityStates in the RN docs. Is this property not actually removed yet? #Closed
There was a problem hiding this comment.
It's removed to my understanding. You could quickly search their view managers in their 0.62 branch though. My guess it that fb has a view manager internally that still allows it, or just forgot to regenerate #Closed
There was a problem hiding this comment.
There were other places in the 0.62 upgrade where it seemed like support was truly removed. #Closed
There was a problem hiding this comment.
|
OK I brought back accessibilityStates so we can backport this to 61 In reply to: 614312986 [](ancestors = 614312986) |
| props.update(folly::dynamic::object("selected", "boolean")("disabled", "boolean")("checked", "boolean")( | ||
| "busy", "boolean")("expanded", "boolean")); | ||
| return props; | ||
| } | ||
| folly::dynamic FrameworkElementViewManager::GetNativeProps() const { | ||
| folly::dynamic props = Super::GetNativeProps(); |
There was a problem hiding this comment.
nit add newline between methods :) #Resolved
kmelmon
added
the
AutoMerge
|
Hello @kmelmon! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
* Implement AccessibilityState * formatting * Change files * bring back accessibilityStates to port back to 0.61 * formatting * handle mixed state * update test * prettier fixes
* Implement accessibilityState (#4617) * Implement AccessibilityState * formatting * Change files * bring back accessibilityStates to port back to 0.61 * formatting * handle mixed state * update test * prettier fixes * resolve merge conflict * idunno what the heck I'm doing but apparently need to change this * f***ing clang * fix merge conflict
* Implement AccessibilityState * formatting * Change files * bring back accessibilityStates to port back to 0.61 * formatting * handle mixed state * update test * prettier fixes
This reverts commit 9718f84.
…yStates * Implement AccessibilityState * formatting * Change files * bring back accessibilityStates to port back to 0.61 * formatting * handle mixed state * update test * prettier fixes
Fixes #4042
In version 0.61, accessibilityState was introduced and accessibilityStates was marked as deprecated.
In version 0.62, accessibilityStates was removed.
This change implements accessibilityState and removes accessibilityStates.
The change is straightforward - instead of an array, the property is an object with fields.
Microsoft Reviewers: Open in CodeFlow