Skip to content

Terminal cannot be opened after adjusting the language #17699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Goo-aw233 opened this issue Aug 10, 2024 · 10 comments
Closed

Terminal cannot be opened after adjusting the language #17699

Goo-aw233 opened this issue Aug 10, 2024 · 10 comments
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.22

Comments

@Goo-aw233
Copy link

Goo-aw233 commented Aug 10, 2024 •
edited
Loading

Windows Terminal version

1.22.2221.0

Windows build number

10.0.26257.5000

Other Software

No response

Steps to reproduce

Open Settings > Appearance > Language > 中文(简体) > Save
Afterwards, close the Settings tab and reopen it. Changing any function and clicking Save will cause the program to crash.
Any language can cause this problem.

Expected Behavior

No response

Actual Behavior

After saving the above changes, Terminal Canary will crash, and after stopping, repairing, or resetting the program, it will not be able to open the program again, and will need to be uninstalled and reinstalled.

Terminal Preview 1.21.1772.0 does not have this problem.

In addition, this is the DMP that is automatically generated after the program crashes.

WindowsTerminal.exe.18664.dmp
@Goo-aw233 Goo-aw233 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 10, 2024
@lhecker
Copy link
Member

lhecker commented Aug 12, 2024

@DHowett How would you like your bad MSVC news today?

@DHowett
Copy link
Member

DHowett commented Aug 12, 2024

Preferably “actionable so we stop getting knocked over by compiler bugs every eight minutes”

@zadjii-msft
Copy link
Member

@lhecker scale of 1-10, how bad is this? This sounds like it's ship blocking

@zadjii-msft zadjii-msft added this to the Terminal v1.22 milestone Aug 20, 2024
@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Aug 20, 2024
@lhecker
Copy link
Member

lhecker commented Aug 20, 2024

I would try disabling PGO as a test. It's possible that it's because I'm using VS 17.11 (and now .12), but this issue doesn't repro for me in local Release builds. Alternatively, we could find a way to get a OneBranch 17.11 image.

@DHowett DHowett mentioned this issue Aug 20, 2024
Merged
DHowett added a commit that referenced this issue Aug 20, 2024
@DHowett
Disable PGO for nightly builds (#17749)
408f3e2 
Refs #17699
@lhecker
Copy link
Member

lhecker commented Aug 21, 2024

Disabling PGO worked: The crash is now fixed in 1.22.2334.0.

@zadjii-msft
Copy link
Member

Okay, so what's the next step here? We can't disable PGO for a real release. Do we just need to roll back the PGO CI to an older VS version?

@DHowett
Copy link
Member

DHowett commented Aug 21, 2024 •
edited
Loading

We can't disable PGO for a real release.

Why not?

Leonard had this to say:

Is there a reason why PGO must be enabled? I thought it's just an optimization.

FWIW, the bug is not in the generation of PGO data (which as of today is on VS 17.11) but in the consumption of it (which is in a onebranch pipeline that is stuck on VS 17.10 -- the known bad compiler.)

@lhecker
Copy link
Member

lhecker commented Aug 21, 2024

Disabling PGO caused a ~13% regression in my testing. It's still magnitudes faster than what it used to be though, so I think we'll be fine even if we never enabled it again. (I think we should though, because PGO is technically really nice.)

@carlos-zamora carlos-zamora added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 21, 2024
@carlos-zamora
Copy link
Member

Since this is now fixed on Canary, and we have a plan moving forward, I'm closing this. Thanks all!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 21, 2024
@Andarwinux
Copy link

Maybe consider trying to use clang-cl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.22
Development

No branches or pull requests
6 participants
@DHowett @lhecker @carlos-zamora @zadjii-msft @Goo-aw233 @Andarwinux