-
Notifications
You must be signed in to change notification settings - Fork 21
chore(catalogue): update test plans re: network links #5004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments!
@@ -48,6 +47,6 @@ A naïve visitor to the data catalogue can click around in the catalogue and und | |||
| | | Name, Description | | | | |||
| | | cdm_1 -> | | | | |||
| 28 | NETWORKS | Part of networks | | | | |||
| | | name for test network of networks, > Website, -> | | | | |||
| | | name for test network of networks, > Website > Network details > Catalogue, -> | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see at this stage whether the test data used in this case has a catalogue, but is it worth adding something here which indicates that the 'catalogue' button only appears if the network in question has a catalogue? Do we perhaps need to add another test step in which we show that a network without a catalogue has no 'catalogue' button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already covered in test plans 5 (step 53) and 9 (step 29), which both have lists of networks, of which some have a catalogue and some don't. This is also why I added the brackets, e.g.
53 | NETWORKS, subtitle: Part of networks | List of networks in which this resource is involved. For each network: logo, name, > Website > Network details (> Catalogue), and an arrow to navigate to details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK great
| | | name for test network of networks | | | | ||
| | | > Website | | | | ||
| | | > Website > Network details > Catalogue | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here as above - perhaps add an extra test step to check what happens when a network doesn't have a catalogue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is covered by the 'name for test network2'-network in the same step, isn't it? That one has no catalogue, so no > Catalogue button should be displayed (which indeed it isn't).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sorry missed that
|
What are the main changes you did