Skip to content

feat: group services in filter by category #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 12, 2025

Conversation

chinook25
Copy link
Contributor

@chinook25 chinook25 commented May 2, 2025

What are the main changes you did

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@chinook25 chinook25 self-assigned this May 2, 2025
@chinook25 chinook25 changed the title feat: retrieve service categories feat: group services in filter by category May 2, 2025
@chinook25 chinook25 marked this pull request as ready for review May 9, 2025 09:47
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory-demo => molgenis_settings.csv file needs to be changed as the new service types filter is now overwritten with the old one

Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested functionality and it works as expected. The grouped and sorted list makes navigating the services much easier.
  • Tested in combination with other facets and this works fine

@chinook25 chinook25 merged commit d492ebc into master May 12, 2025
7 checks passed
@chinook25 chinook25 deleted the feat/expanded-services-filter branch May 12, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(directory): Group service type filter options by serviceCategory
3 participants