Extensions: Added uninstall and update process

src/framework/extensions/extensionstypes.h

@@ -218,6 +218,7 @@ struct Manifest {
     };
 
     Uri uri;
+    io::path_t path;
     Type type = Type::Undefined;
     String title;
     String description;
@@ -226,6 +227,7 @@ struct Manifest {
     String version;
     int apiversion = DEFAULT_API_VERSION;
     bool legacyPlugin = false;
+    bool isUserExtension = false;
 
     std::vector<Action> actions;
 

src/framework/extensions/iextensionsprovider.h

@@ -38,6 +38,7 @@ class IExtensionsProvider : MODULE_EXPORT_INTERFACE
     virtual ~IExtensionsProvider() = default;
 
     virtual void reloadExtensions() = 0;
+    virtual Ret removeExtension(const Uri& uri) = 0;
 
     virtual ManifestList manifestList(Filter filter = Filter::All) const = 0;
     virtual async::Notification manifestListChanged() const = 0;

src/framework/extensions/internal/extensioninstaller.cpp

@@ -2,6 +2,7 @@
 
 #include "global/io/fileinfo.h"
 #include "global/serialization/zipreader.h"
+#include "global/translation.h"
 #include "global/uuid.h"
 
 #include "../extensionstypes.h"
@@ -36,11 +37,40 @@ Ret ExtensionInstaller::installExtension(const io::path_t srcPath)
         ExtensionsLoader loader;
         Manifest m = loader.parseManifest(data);
 
-        bool hasSame = provider()->manifest(m.uri).isValid();
-        if (hasSame) {
+        Manifest existingManifest = provider()->manifest(m.uri);
+        bool alreadyInstalled = existingManifest.isValid();
+        if (alreadyInstalled && existingManifest.version == m.version) {
             LOGI() << "already installed: " << m.uri;
+
+            interactive()->info(trc("extensions", "The extension is already installed."), std::string(),
+                                { interactive()->buttonData(IInteractive::Button::Ok) });
+
+            return make_ok();
+        }
+
+        if (alreadyInstalled && !existingManifest.isUserExtension) {
+            interactive()->error(trc("extensions", "This extension cannot be updated."), std::string(),
+                                 { interactive()->buttonData(IInteractive::Button::Ok) });
+
             return make_ok();
         }
+
+        if (alreadyInstalled) {
+            std::string text = qtrc("extensions", "Another version of the extension “%1” is already installed (version %2). "
+                                                  "Do you want to replace it with version %3?")
+                               .arg(existingManifest.title, existingManifest.version, m.version).toStdString();
+
+            IInteractive::Result result = interactive()->question(trc("extensions", "Update Extension"), text, {
+                interactive()->buttonData(IInteractive::Button::Cancel),
+                interactive()->buttonData(IInteractive::Button::Ok)
+            });
+
+            if (result.button() == int(IInteractive::Button::Ok)) {
+                provider()->removeExtension(existingManifest.uri);
+            } else {
+                return make_ok();
+            }
+        }
     }
 
     // unpack

src/framework/extensions/internal/extensioninstaller.h

@@ -5,12 +5,16 @@
 #include "modularity/ioc.h"
 #include "../iextensionsconfiguration.h"
 #include "../iextensionsprovider.h"
+#include "global/iinteractive.h"
+#include "io/ifilesystem.h"
 
 namespace muse::extensions {
 class ExtensionInstaller : public IExtensionInstaller
 {
     muse::GlobalInject<IExtensionsConfiguration> configuration;
     muse::GlobalInject<IExtensionsProvider> provider;
+    muse::GlobalInject<muse::IInteractive> interactive;
+    muse::GlobalInject<io::IFileSystem> fileSystem;
 
 public:
     ExtensionInstaller() = default;

src/framework/extensions/internal/extensionsloader.cpp

@@ -58,7 +58,7 @@ ManifestList ExtensionsLoader::loadManifestList(const io::path_t& defPath, const
         retList.push_back(m);
     }
 
-    for (const Manifest& m : externalManifests) {
+    for (Manifest& m : externalManifests) {
         if (!m.isValid()) {
             continue;
         }
@@ -67,6 +67,7 @@ ManifestList ExtensionsLoader::loadManifestList(const io::path_t& defPath, const
             continue;
         }
 
+        m.isUserExtension = true;
         retList.push_back(m);
     }
 
@@ -80,6 +81,7 @@ ManifestList ExtensionsLoader::manifestList(const io::path_t& rootPath) const
     for (const io::path_t& path : paths) {
         LOGD() << "parsing manifest: " << path;
         Manifest manifest = parseManifest(path);
+        manifest.path = path;
         resolvePaths(manifest, io::FileInfo(path).dirPath());
         manifests.push_back(manifest);
     }

src/framework/extensions/internal/extensionsprovider.cpp

@@ -23,6 +23,7 @@
 
 #include "global/containers.h"
 #include "global/async/async.h"
+#include "global/io/path.h"
 
 #include "extensionsloader.h"
 #include "legacy/extpluginsloader.h"
@@ -68,6 +69,25 @@ void ExtensionsProvider::reloadExtensions()
     m_manifestListChanged.notify();
 }
 
+muse::Ret ExtensionsProvider::removeExtension(const Uri& uri)
+{
+    const Manifest manifest = this->manifest(uri);
+    if (!manifest.isValid()) {
+        return make_ret(Ret::Code::UnknownError);
+    }
+
+    io::path_t path = manifest.path;
+
+    Ret ret = fileSystem()->remove(io::dirpath(path));
+    if (!ret) {
+        LOGE() << "Failed to delete the folder: " << path;
+        return ret;
+    }
+
+    reloadExtensions();
+    return make_ok();
+}
+
 ManifestList ExtensionsProvider::manifestList(Filter filter) const
 {
     if (filter == Filter::Enabled) {

src/framework/extensions/internal/extensionsprovider.h

@@ -29,19 +29,22 @@
 #include "../iextensionsprovider.h"
 #include "../iextensionsexecpointsregister.h"
 #include "global/iinteractive.h"
+#include "io/ifilesystem.h"
 
 namespace muse::extensions {
 class ExtensionsProvider : public IExtensionsProvider, public Injectable, public async::Asyncable
 {
     Inject<IExtensionsConfiguration> configuration = { this };
     Inject<IExtensionsExecPointsRegister> execPointsRegister = { this };
     Inject<IInteractive> interactive = { this };
+    Inject<io::IFileSystem> fileSystem  = { this };
 
 public:
     ExtensionsProvider(const modularity::ContextPtr& iocCtx)
         : Injectable(iocCtx) {}
 
     void reloadExtensions() override;
+    Ret removeExtension(const Uri& uri) override;
 
     ManifestList manifestList(Filter filter = Filter::All) const override;
     async::Notification manifestListChanged() const override;

src/framework/extensions/internal/legacy/extpluginsloader.cpp

@@ -76,10 +76,11 @@ ManifestList ExtPluginsLoader::loadManifestList(const io::path_t& defPath, const
         retList.push_back(m);
     }
 
-    for (const Manifest& m : externalManifests) {
+    for (Manifest& m : externalManifests) {
         if (!m.isValid()) {
             continue;
         }
+        m.isUserExtension = true;
         retList.push_back(m);
     }
 
@@ -95,6 +96,7 @@ ManifestList ExtPluginsLoader::manifestList(const io::path_t& rootPath) const
         if (!manifest.isValid()) {
             continue;
         }
+        manifest.path = path;
         resolvePaths(manifest, io::FileInfo(path).dirPath());
         manifests.push_back(manifest);
     }

src/framework/extensions/qml/Muse/Extensions/ExtensionsListPanel.qml

@@ -187,6 +187,7 @@ Item {
         background: flickable
 
         isEnabled: Boolean(selectedPlugin) ? selectedPlugin.enabled : false
+        isUserExtension: Boolean(selectedPlugin) ? selectedPlugin.isUserExtension : false
 
         additionalInfoModel: [
             {"title": qsTrc("extensions", "Version:"), "value": Boolean(selectedPlugin) ? selectedPlugin.version : "" },
@@ -198,6 +199,12 @@ Item {
             extensionsModel.selectExecPoint(selectedPlugin.uri, index)
         }
 
+        onRemove: function() {
+            extensionsModel.removeExtension(selectedPlugin.uri)
+            prv.resetSelectedPlugin()
+            panel.close()
+        }
+
         onEditShortcutRequested: {
             Qt.callLater(extensionsModel.editShortcut, selectedPlugin.uri)
             panel.close()

src/framework/extensions/qml/Muse/Extensions/internal/EnablePanel.qml

@@ -32,9 +32,11 @@ InfoPanel {
 
     property var execPointsModel: null
     property int currentExecPointIndex: 0
+    property bool isUserExtension: false
 
     signal editShortcutRequested()
     signal execPointSelected(int index)
+    signal remove()
 
     buttonsPanel: RowLayout {
         id: buttons
@@ -84,37 +86,62 @@ InfoPanel {
             }
         }
 
-
-
-        FlatButton {
-            id: mainButton
+        RowLayout {
             Layout.alignment: Qt.AlignRight
+            spacing: 22
+
+            FlatButton {
+                id: removeButton
+
+                visible: root.isUserExtension
+                navigation.name: text + "Button"
+                navigation.panel: root.contentNavigation
+                navigation.column: 2
+                accessible.ignored: true
+                navigation.onActiveChanged: {
+                    if (!navigation.active) {
+                        accessible.ignored = false
+                    }
+                }
 
-            navigation.name: text + "Button"
-            navigation.panel: root.contentNavigation
-            navigation.column: 3
-            accessible.ignored: true
-            navigation.onActiveChanged: {
-                if (!navigation.active) {
-                    accessible.ignored = false
+                text: qsTrc("workspace", "Remove")
+
+                onClicked: {
+                    root.remove()
                 }
             }
 
-            text: !root.isEnabled ? qsTrc("extensions", "Enable") : qsTrc("extensions", "Disable")
 
-            Component.onCompleted: {
-                root.mainButton = mainButton
-            }
 
-            onClicked: {
-                //! NOTE temporary
-                // The function with the choice of the call point is not ready yet.
-                // Therefore, here is the previous solution with the button,
-                // but in fact the choice is made from the list
-                // 0 - disabled
-                // 1 - enabled (manual call)
-                // (here we switch to the opposite state)
-                root.execPointSelected(root.isEnabled ? 0 : 1)
+            FlatButton {
+                id: mainButton
+
+                navigation.name: text + "Button"
+                navigation.panel: root.contentNavigation
+                navigation.column: 3
+                accessible.ignored: true
+                navigation.onActiveChanged: {
+                    if (!navigation.active) {
+                        accessible.ignored = false
+                    }
+                }
+
+                text: !root.isEnabled ? qsTrc("extensions", "Enable") : qsTrc("extensions", "Disable")
+
+                Component.onCompleted: {
+                    root.mainButton = mainButton
+                }
+
+                onClicked: {
+                    //! NOTE temporary
+                    // The function with the choice of the call point is not ready yet.
+                    // Therefore, here is the previous solution with the button,
+                    // but in fact the choice is made from the list
+                    // 0 - disabled
+                    // 1 - enabled (manual call)
+                    // (here we switch to the opposite state)
+                    root.execPointSelected(root.isEnabled ? 0 : 1)
+                }
             }
         }
     }

src/framework/extensions/view/extensionslistmodel.cpp

@@ -44,6 +44,7 @@ ExtensionsListModel::ExtensionsListModel(QObject* parent)
         { rCategory, "category" },
         { rVersion, "version" },
         { rShortcuts, "shortcuts" },
+        { rIsUserExtension, "isUserExtension" }
     };
 }
 
@@ -120,6 +121,9 @@ QVariant ExtensionsListModel::data(const QModelIndex& index, int role) const
         //: No keyboard shortcut is assigned to this plugin.
         return muse::qtrc("extensions", "Not defined");
     }
+    case rIsUserExtension: {
+        return plugin.isUserExtension;
+    }
     }
 
     return QVariant();
@@ -219,6 +223,11 @@ void ExtensionsListModel::reloadPlugins()
     provider()->reloadExtensions();
 }
 
+void ExtensionsListModel::removeExtension(const QString& uri)
+{
+    provider()->removeExtension(Uri(uri.toStdString()));
+}
+
 QVariantList ExtensionsListModel::categories() const
 {
     QVariantList result;

src/framework/extensions/view/extensionslistmodel.h

@@ -58,6 +58,7 @@ class ExtensionsListModel : public QAbstractListModel, public Injectable, public
 
     Q_INVOKABLE void editShortcut(const QString& uri);
     Q_INVOKABLE void reloadPlugins();
+    Q_INVOKABLE void removeExtension(const QString& uri);
 
     Q_INVOKABLE QVariantList categories() const;
 
@@ -73,7 +74,8 @@ class ExtensionsListModel : public QAbstractListModel, public Injectable, public
         rEnabled,
         rCategory,
         rVersion,
-        rShortcuts
+        rShortcuts,
+        rIsUserExtension
     };
 
     struct ExecPoints {