Skip to content

Extensions: Added uninstall and update process #27768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Kavakuo
Copy link

@Kavakuo Kavakuo commented Apr 20, 2025

Hi all,
I recently played around with the new extension format (.mext) and noticed that it is currently not possible to ship updates for an extension without performing a manual update process (deleting the folder, drag&drop the extension for installation). I didn't find any issues for this, so I thought this could be a small fun weekend project. So this PR introduces two new features improve the process:

  • Added two new modal popups (1e981f7)
    • When the user tries to install the extension with the same version
    • When the user tries to install the extension with another version. The popup contains the current and old version number. If the user agrees, the old version is removed and the new version is installed.
  • Added a button to the extension panel, to be able to remove/uninstall an extension (e371e3d)

I am no C++ expert, so please let me know if you see any room for improvements that I should change.

Remaining ToDos:

  • Localization of the strings in the modal popup. I probably need some help here, since I don't know the workflow.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@Kavakuo Kavakuo force-pushed the extensions-update branch from 4dd4aaa to f5ccd82 Compare April 21, 2025 10:37
Kavakuo added 2 commits April 21, 2025 12:44
(cherry picked from commit 585139b)
@Kavakuo Kavakuo force-pushed the extensions-update branch from f5ccd82 to e371e3d Compare April 21, 2025 10:44
@cbjeukendrup cbjeukendrup requested a review from bkunda April 21, 2025 21:44
@Kavakuo
Copy link
Author

Kavakuo commented Apr 22, 2025

Thanks for the fast review @cbjeukendrup! I added a commit to address your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants