fs: remove recursive option from rmdir
#57784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiviaMedeiros
added
fs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57784 +/- ##
========================================
Coverage 90.24% 90.25%
========================================
Files 630 630
Lines 185245 185136 -109
Branches 36299 36286 -13
========================================
- Hits 167173 167090 -83
+ Misses 11018 10988 -30
- Partials 7054 7058 +4
🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
Apr 7, 2025
MoLow
approved these changes
Apr 7, 2025
jazelly
approved these changes
Apr 7, 2025
RaisinTen
approved these changes
Apr 8, 2025
lpinca
approved these changes
Apr 9, 2025
|
There seem to be a lot of CITGM failures compared to main. |
|
Closed in favour of #58616 |
|
oh! I had completely missed this @LiviaMedeiros ! Sorry about that :-*( |
|
No worries; as long as the change lands, am happy with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves DEP0147: fs.rmdir(path, { recursive: true }) to EOL.
The
recursiveoption was runtime deprecated since v16.0.0 in favor ofrm()function. Maybe it is time to remove it.cc @nodejs/fs because fsIssues and PRs related to the fs subsystem / file system.
PRs that contain breaking changes and should be released in the next major version.
cc @nodejs/tsc because semver-major
cc @addaleax because of concerns in the runtime deprecation PR #37302 (comment)