Skip to content

fs: move rmdir recursive option to end-of-life #58616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2025
Merged

fs: move rmdir recursive option to end-of-life #58616

merged 2 commits into from
Jun 21, 2025

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jun 7, 2025

Has been runtime deprecated for ~ 5 years now. It's time.

@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 7, 2025
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 7, 2025
@jasnell jasnell added deprecations Issues and PRs related to deprecations. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. and removed fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 7, 2025
@jasnell jasnell requested review from mcollina, anonrig and mhdawson June 7, 2025 14:44
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
jasnell
jasnell commented Jun 7, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jun 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (5fe7800) to head (5d2b775).
Report is 33 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58616   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files         637      637           
  Lines      188001   188081   +80     
  Branches    36881    36891   +10     
=======================================
+ Hits       169509   169584   +75     
- Misses      11238    11264   +26     
+ Partials     7254     7233   -21
Files with missing lines Coverage Δ
lib/fs.js 98.16% <100.00%> (-0.02%) ⬇️
lib/internal/fs/promises.js 98.09% <100.00%> (ø)
lib/internal/fs/utils.js 99.68% <100.00%> (-0.01%) ⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dario-piotrowicz
dario-piotrowicz approved these changes Jun 7, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 😄 🚀

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 7, 2025
mcollina
mcollina reviewed Jun 8, 2025
View reviewed changes
@jasnell jasnell force-pushed the jasnell/eol-rmdir-recursive branch from 7396177 to 0be4c18 Compare June 8, 2025 16:17
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell requested a review from mcollina June 8, 2025 18:23
LiviaMedeiros
LiviaMedeiros reviewed Jun 9, 2025
View reviewed changes
Copy link
Member

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI #57784... At that time there were some failures in CITGM, IIRC in only a few packages, I couldn't reproduce it locally (maybe failures were indirectly caused by some preinstall jobs).
If we want to land this PR, it should also adjust doc/api/fs.md.

@jasnell
Copy link
Member Author

jasnell commented Jun 13, 2025

@nodejs/tsc please :-)

targos
targos requested changes Jun 13, 2025
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation should be updated to delete the removed options

@jasnell jasnell force-pushed the jasnell/eol-rmdir-recursive branch 2 times, most recently from 46c24f8 to 98d4b96 Compare June 14, 2025 17:03
@jasnell jasnell requested a review from targos June 14, 2025 17:03
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
fs: move rmdir recursive option to end-of-life
3cf7032 
Has been runtime deprecated for ~ 5 years now. It's time.
@jasnell jasnell force-pushed the jasnell/eol-rmdir-recursive branch from 98d4b96 to 3cf7032 Compare June 14, 2025 17:15
LiviaMedeiros
LiviaMedeiros approved these changes Jun 14, 2025
View reviewed changes
@LiviaMedeiros LiviaMedeiros mentioned this pull request Jun 14, 2025
Closed
jasnell
jasnell commented Jun 14, 2025
View reviewed changes
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67575/

mcollina
mcollina approved these changes Jun 21, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jun 21, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2025
@nodejs-github-bot nodejs-github-bot merged commit eec0302 into nodejs:main Jun 21, 2025
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eec0302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@mhdawson mhdawson Awaiting requested review from mhdawson

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. deprecations Issues and PRs related to deprecations. fs Issues and PRs related to the fs subsystem / file system. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jasnell @nodejs-github-bot @mcollina @panva @anonrig @targos @Ethan-Arrowood @RafaelGSS @dario-piotrowicz @LiviaMedeiros