Properly handle update-requests capabilities and always use context I/O #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aymanbagabas I see some failures in checks. Would you like me to rebase and merge it anyway or are you planning on fixing it? |
The failures are unrelated to the file transport issue. I'm planning to look into them next. Let's merge this one and look into the other issues in a separate PR. |
onee-only
merged commit 0676a21
into
onee-only:v6-transport-expose-test
2 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues with the tests always passing a packfile even if the operation doesn't expect one. We also need to selectively set
update-requestscapabilities in commands. DuringUploadPackandRecievePack, we use context I/O after checking whether we have reader/writer.It also adds the
report-status-v2capability const.