Skip to content

Add FS Health Check Failure Metric #18435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bhumikasharma29
Copy link
Contributor

Description

This PR will add a metric when there is FS health check failure. The tag will contain detail about the node whose FS health check has failed.
Continues from #17949

Related Issues

None

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bhumikasharma29 bhumikasharma29 marked this pull request as ready for review June 4, 2025 04:54
@bhumikasharma29 bhumikasharma29 requested a review from a team as a code owner June 4, 2025 04:54
Copy link
Contributor

github-actions bot commented Jun 4, 2025

❌ Gradle check result for 6755af1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 4, 2025

✅ Gradle check result for 63aa329: SUCCESS

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.78%. Comparing base (5255f5b) to head (0f50620).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18435      +/-   ##
============================================
+ Coverage     72.71%   72.78%   +0.07%     
- Complexity    68094    68159      +65     
============================================
  Files          5537     5537              
  Lines        313312   313331      +19     
  Branches      45460    45462       +2     
============================================
+ Hits         227813   228060     +247     
+ Misses        66967    66728     -239     
- Partials      18532    18543      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/fs-health-failure-metric branch 2 times, most recently from 99b0993 to 964b281 Compare June 7, 2025 10:02
Copy link
Contributor

github-actions bot commented Jun 7, 2025

❌ Gradle check result for 964b281: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Gaganjuneja
Copy link
Contributor

@Bukhtawar @sachinpkale Could you please take a look at this as well. Thanks.

Copy link
Contributor

github-actions bot commented Jun 8, 2025

❌ Gradle check result for 60605ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@Gaganjuneja Gaganjuneja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure all the tests are passing.

Copy link
Contributor

github-actions bot commented Jun 8, 2025

❌ Gradle check result for 9bab310: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 9, 2025

❌ Gradle check result for e831ed6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 9, 2025

✅ Gradle check result for 21b3b90: SUCCESS

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/fs-health-failure-metric branch from 21b3b90 to e42e853 Compare June 10, 2025 09:00
Copy link
Contributor

❌ Gradle check result for e42e853: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/fs-health-failure-metric branch 2 times, most recently from 3f1f587 to 4beaeb6 Compare June 10, 2025 11:06
Copy link
Contributor

❌ Gradle check result for 4beaeb6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bhumikasharma29
Copy link
Contributor Author

Flaky test caused gradle to fail - #14509

Copy link
Contributor

❌ Gradle check result for 7d0a0bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bhumikasharma29
Copy link
Contributor Author

flaky test failed - #14509

Bhumika Sharma added 6 commits June 11, 2025 12:44
@bhumikasharma29 bhumikasharma29 force-pushed the bhumika/fs-health-failure-metric branch from 7d0a0bf to dd147f1 Compare June 11, 2025 07:46
Copy link
Contributor

❌ Gradle check result for dd147f1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Bhumika Sharma <[email protected]>
@bhumikasharma29
Copy link
Contributor Author

Flaky test failed - #14294

@bhumikasharma29
Copy link
Contributor Author

Flaky tests -
#15813
#18490

Copy link
Contributor

❌ Gradle check result for 6e531e5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Bhumika Sharma added 2 commits June 11, 2025 15:30
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
@bhumikasharma29
Copy link
Contributor Author

flaky test - #14407

Signed-off-by: Bhumika Sharma <[email protected]>
Copy link
Contributor

✅ Gradle check result for 0f50620: SUCCESS

@Bukhtawar Bukhtawar merged commit c92b8ea into opensearch-project:main Jun 11, 2025
30 checks passed
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 17, 2025
* Add FS Health Check Failure Metric

Signed-off-by: Bhumika Sharma <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
* Add FS Health Check Failure Metric

Signed-off-by: Bhumika Sharma <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
* Add FS Health Check Failure Metric

Signed-off-by: Bhumika Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants