-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add FS Health Check Failure Metric #18435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FS Health Check Failure Metric #18435
Conversation
❌ Gradle check result for 6755af1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18435 +/- ##
============================================
+ Coverage 72.71% 72.78% +0.07%
- Complexity 68094 68159 +65
============================================
Files 5537 5537
Lines 313312 313331 +19
Branches 45460 45462 +2
============================================
+ Hits 227813 228060 +247
+ Misses 66967 66728 -239
- Partials 18532 18543 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
server/src/main/java/org/opensearch/monitor/fs/FsHealthService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/monitor/fs/FsHealthService.java
Outdated
Show resolved
Hide resolved
99b0993
to
964b281
Compare
❌ Gradle check result for 964b281: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/monitor/fs/FsHealthService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/monitor/fs/FsHealthService.java
Outdated
Show resolved
Hide resolved
@Bukhtawar @sachinpkale Could you please take a look at this as well. Thanks. |
❌ Gradle check result for 60605ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/monitor/fs/FsHealthService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure all the tests are passing.
❌ Gradle check result for 9bab310: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/monitor/fs/FsHealthService.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for e831ed6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
7d54b37
to
21b3b90
Compare
server/src/test/java/org/opensearch/telemetry/TestInMemoryCounter.java
Outdated
Show resolved
Hide resolved
21b3b90
to
e42e853
Compare
❌ Gradle check result for e42e853: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3f1f587
to
4beaeb6
Compare
❌ Gradle check result for 4beaeb6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test caused gradle to fail - #14509 |
❌ Gradle check result for 7d0a0bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
flaky test failed - #14509 |
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
7d0a0bf
to
dd147f1
Compare
❌ Gradle check result for dd147f1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bhumika Sharma <[email protected]>
Flaky test failed - #14294 |
❌ Gradle check result for 6e531e5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bhumika Sharma <[email protected]>
Signed-off-by: Bhumika Sharma <[email protected]>
flaky test - #14407 |
Signed-off-by: Bhumika Sharma <[email protected]>
* Add FS Health Check Failure Metric Signed-off-by: Bhumika Sharma <[email protected]>
* Add FS Health Check Failure Metric Signed-off-by: Bhumika Sharma <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
* Add FS Health Check Failure Metric Signed-off-by: Bhumika Sharma <[email protected]>
Description
This PR will add a metric when there is FS health check failure. The tag will contain detail about the node whose FS health check has failed.
Continues from #17949
Related Issues
None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.