2: Hide synced spaces in spaces browser #11759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
commented
Jul 26, 2024
| @@ -130,6 +123,9 @@ ecm_add_qml_module(owncloudGui | |||
| qml/AccountButton.qml | |||
| qml/FolderDelegate.qml | |||
| qml/FolderError.qml | |||
|
|
|||
| spaces/qml/SpaceDelegate.qml | |||
There was a problem hiding this comment.
Adding the qml file in the subdirectory failed during the cache generation so I had to move it here.
| @@ -1,25 +1,7 @@ | |||
| add_library(ownCloudSpaces SHARED | |||
| target_sources(owncloudGui | |||
There was a problem hiding this comment.
I finally had to merge the spaces browser into the gui module....
In order to track which spaces are synced I needed to access the folder manager.....
TheOneRing
force-pushed
the
work/hide_synced
branch
from
63eed87 to
fd8a62a
Compare
TheOneRing
changed the title
erikjv
previously approved these changes
Jul 29, 2024
TheOneRing
force-pushed
the
work/hide_synced
branch
from
3f1d43d to
7c117c2
Compare
|
@saw-jan this changes breaks a gui test as your synced the same space multiple times. |
erikjv
approved these changes
Jul 29, 2024
Will have a look. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11752
Depends on #11758