Skip to content

Reintroduce the --wheel CLI option, even though it has no effect on Python > 3.8 #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented May 6, 2025

No description provided.

@hroncok hroncok changed the title Reintroduce the --wheel CLI option, even though it has no effect on Python >= 3.8 Reintroduce the --wheel CLI option, even though it has no effect on Python > 3.8 May 7, 2025
@hroncok hroncok force-pushed the wheel-option-back branch 4 times, most recently from 32fbde1 to 1cb91bd Compare May 8, 2025 17:22
…ython > 3.8

Also, make the warning visible to the users.
And, fix the message to say > 3.8 instead of >= 3.8.
@hroncok hroncok force-pushed the wheel-option-back branch from 1cb91bd to a15bd55 Compare May 8, 2025 17:25
@hroncok hroncok marked this pull request as ready for review May 8, 2025 17:26
@gaborbernat gaborbernat merged commit 9c4cd8e into pypa:main May 8, 2025
42 checks passed
@hroncok hroncok deleted the wheel-option-back branch May 12, 2025 23:07
@hroncok
Copy link
Contributor Author

hroncok commented May 12, 2025

For the record, based on tox-dev/tox#3528 I now see that this also warns when $VIRTUALENV_WHEEL is set.

This was not my intention. Should we keep it that way? And if so, should the warning be adjusted to mention it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants