Skip to content

Fix using deprecated virtualenv option --wheel #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

robsdedude
Copy link
Contributor

The CI started failing when virtualenv deprecated the --wheel and --no-wheel options (in 20.31.0). This PR makes it so that tox doesn't run into this deprecation which caused the tests to fail that checked for some expected stdout which were then unexpectedly containing the deprecation message.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
    (Existing test were failing, so if this improves the situation, I consider this box ticked 😉)
  • added news fragment in docs/changelog folder not user-facing, or it it?
  • updated/extended the documentation API/CLI didn't change

@robsdedude robsdedude requested a review from gaborbernat as a code owner May 11, 2025 20:19
@robsdedude robsdedude marked this pull request as draft May 11, 2025 20:29
@robsdedude
Copy link
Contributor Author

This turns out to be more involved than I anticipated it to be 😇

I think to be able to get rid of using virtualenv to install wheel, pyproject-api needs to be update to not require wheel. Which would be in line with the pyproject.toml specs:

[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools"]

Build tools are expected to use the example configuration file above as their default semantics when a pyproject.toml file is not present.

I think it might be this line that's causing issues: https://github.com/tox-dev/pyproject-api/blob/46dc443b1a33599fb76f869bd911fd4827eafb0d/src/pyproject_api/_frontend.py#L179

@gaborbernat
Copy link
Member

This turns out to be more involved than I anticipated it to be 😇

I think to be able to get rid of using virtualenv to install wheel, pyproject-api needs to be update to not require wheel. Which would be in line with the pyproject.toml specs:

[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools"]

Build tools are expected to use the example configuration file above as their default semantics when a pyproject.toml file is not present.

I think it might be this line that's causing issues: tox-dev/pyproject-api@46dc443/src/pyproject_api/_frontend.py#L179

You're correct here.

@gaborbernat
Copy link
Member

https://github.com/tox-dev/pyproject-api/releases/tag/1.9.1

@hroncok
Copy link
Contributor

hroncok commented May 12, 2025

With pyproject-api 1.9.1, this works and fixes the issue for me.

gaborbernat
gaborbernat previously approved these changes May 12, 2025
Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat force-pushed the tests/fix-virtuelenv-deprecation branch from a2dd77a to 4d68d2a Compare May 12, 2025 18:25
@gaborbernat gaborbernat marked this pull request as ready for review May 12, 2025 19:40
@gaborbernat gaborbernat merged commit 51aac32 into tox-dev:main May 12, 2025
28 checks passed
@robsdedude robsdedude deleted the tests/fix-virtuelenv-deprecation branch May 12, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants