-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Upgrade to Hibernate ORM 7 #41310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Hibernate ORM 7 #41310
Conversation
85327ca
to
8d25fb0
Compare
Should we try to coordinate the Jakarta EE 11 updates? |
Quarkus definitely should plan for that, yes. I don't know the full implications for Quarkus, but I think at least CDI, Narayana and Validator (so probably EL too?) will need to be upgraded before or at the same time as we upgrade to Hibernate ORM 7.0. As well as Search and Reactive, of course. Fair warning though:
I'll set a reminder to ping you when I have a clearer view of what works and what doesn't in Quarkus itself. |
464af78
to
5f014d5
Compare
🙈 The PR is closed and the preview is expired. |
I identified the Kotlin failures as a bug in hibernate-models: hibernate/hibernate-models#99 |
The XML mapping issue seems caused by https://hibernate.atlassian.net/browse/HHH-18662. |
Alright, I think I did all I could at this point. I will need new Beta releases of Hibernate ORM / Search / Reactive to go further. |
And remove Hibernate Commons Annotations, which isn't needed by any Hibernate project anymore.
…ibernate Search 8.0.0.Beta1
… / Hibernate Search 8.0.0.CR1
to match the one used in Hibernate Search
…(proxyClass = ...)` This is the recommended approach to migrate. That, or using `Hibernate.unproxy()` if the impact of `@ConcreteProxy` on SQL performance is not acceptable. See https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/HHH-18194/near/467597335
This means we' temporarily misaligned with the version used in ORM 7.0.0.Final, but that version is a CR3 so we don't want it in Quarkus, and anyway to misalignment should be fine as no change was necessary in ORM for the upgrade: https://github.com/hibernate/hibernate-orm/pull/10282/files
To align on Hibernate Search: https://docs.jboss.org/hibernate/search/8.0/migration/html_single/#configuration See here for the rationale: https://hibernate.atlassian.net/issues/HSEARCH-5045
Hibernate Search complies with jboss.log-version, see io.quarkus.runtime.logging.JBossVersion
Thanks for the review. I addressed comments and rebased on main. Let's wait for CI and merge, the deadline is close :] |
It makes sense thanks! |
Status for workflow
|
Status for workflow
|
Thank you! I added the relevant information to the migrationg guide: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.24#jakarta-persistence-hibernate-orm |
This upgrades Quarkus to Hibernate ORM 7.
Based on #41359, which must be merged first.=> DoneMigration guide entry:
Status / next steps:
StackOverflowError
hibernate/hibernate-models#99)HHH-
) and remove them if they are no longer necessary -- see in particular https://hibernate.atlassian.net/browse/HHH-19033quarkus-update
jakarta.persistence.SchemaManager
-- see Add CDI support for additional JPA/Hibernate components #47792