Delegate detection of the database version to the Hibernate ORM dialect and enable checks for Hibernate Reactive

[yrodiere]

Fixes #43703
Fixes #42255
Fixes #45263

Based on #41310, which must be merged first. Critically, #41310 requires Hibernate ORM 7.0.0.Final to be released, so we won't be able to merge this PR for a while. I'm submitting it anyway as a draft, so that we remember it's that easy: only the last two commits will be needed after we rebase. => #41310 was merged

[quarkus-bot]

/cc @gsmet (hibernate-orm)

[DavideD]

Before merging this, we should check that it works with Hibernate Reactive.

[yrodiere]

I rebased on the ORM 7 upgrade PR (which upgrades to Reactive 3.0.0.CR1 too, now), and added tests to check DB version checking works with Hibernate Reactive, but so far it does not. I think QuarkusRuntimeInitDialectFactory is never used in reactive, leading to the DB version being unavailable and thus never checked.

I'll get back to this later, will try to fix it, and will update the Hibernate Reactive extension docs (since we need to document the DB version stuff there, too).

[github-actions]

🙈 The PR is closed and the preview is expired.

[yrodiere]

Let's see what CI has to say, I'm seeing weird test failures for Gradle in my fork...

[yrodiere]

There's definitely something wrong, and fortunately my new DbOfflineOnStartupTest seems to reproduce that. I'll need to have a closer look, but we'll miss the Quarkus 3.24.0.CR1 release. Well, we'll catch the next one :)

[yrodiere]

There's definitely something wrong, and fortunately my new DbOfflineOnStartupTest seems to reproduce that. I'll need to have a closer look, but we'll miss the Quarkus 3.24.0.CR1 release. Well, we'll catch the next one :)

Should be good now.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b1e43b2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - History

• io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor\#startRedisContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redis:7 at io.quarkus.redis.deployment.client.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:131) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException

java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.redis.deployment.client.DevServicesRedisProcessor#startRedisContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/redis:7
	at io.quarkus.redis.deployment.client.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:131)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

Addressed.

[yrodiere]

I added entries to the migration guide:

https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.25#database-versions-checks
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.25#database-versions-checks-1